Re: [PATCH 4/4] remoteproc: qcom: pas: Add Glymur OOBMSS coredump support

[Krzysztof Kozlowski <krzk@kernel.org>]

On 12/10/2026 11:50, Anvesh Jain P wrote:
> 
> 
> On 10/12/2026 2:26 PM, Krzysztof Kozlowski wrote:
>> On Fri, Oct 09, 2026 at 12:47:42PM +0530, Anvesh Jain P wrote:
>>> Add coredump support for the secure and non-secure OOBMSS carveouts.
>>> Register fixed dump segments at probe time for attached-state recovery.
>>>
>>> Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
>>> ---
>>>  drivers/remoteproc/qcom_q6v5_pas.c | 85 ++++++++++++++++++++++++++++++++++----
>>>  1 file changed, 77 insertions(+), 8 deletions(-)
>>
>> Why is this separate from Glymur support? How is your device suppose to
>> work without this patch?
>>
>> Best regards,
>> Krzysztof
> 
> This patch is diagnostic-only and is not required for OOBMSS boot or SSR
> recovery; without it, the device works but no OOB coredump is collected.
> 
> I kept it separate to isolate the optional coredump support. I will make
> the subject and description generic for coredump support on PAS
> subsystems with secondary processors, rather than limiting it to
> Glymur/OOBMSS.
> 

Commit msg probably should mention that "recovery" is here for
debugging, not proper device operation. Otherwise single commit, if
moderately small, is usually bringing entire support for a device.

Best regards,
Krzysztof