From: Krzysztof Kozlowski <krzk@kernel.org>
To: Zoltan HERPAI <wigyori@uid0.hu>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
Frank.Li@nxp.com, s.hauer@pengutronix.de, festevam@gmail.com,
kernel@pengutronix.de
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: imx8mp: add Olimex i.MX8MP-SOM-EVB kit
Date: Sat, 19 Sep 2026 09:10:43 +0200 [thread overview]
Message-ID: <77606157-1d09-45a9-bf1c-b8c1d921cee3@kernel.org> (raw)
In-Reply-To: <20260918195559.130443-3-wigyori@uid0.hu>
On 18/09/2026 21:55, Zoltan HERPAI wrote:
> This adds support for an i.MX8-based system-on-module + EVB board. The
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
> product pages are here [1] and here [2] respectively.
>
> There are two new files, one dts for the EVB and one dtsi for the SoM.
>
...
> +&ecspi2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi2 &pinctrl_ecspi2_cs>;
> +
> + status = "okay";
> +
> + spidev1: spi@0 {
> + reg = <0>;
> + compatible = "rohm,dh2228fv";
No, strong no. This does not exist. Don't invent fake devices on your board.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-19 7:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 19:55 [PATCH 0/2] arm64: add support for Olimex i.MX8MP-SOM-EVB kit Zoltan HERPAI
2026-09-18 19:55 ` [PATCH 1/2] dt-bindings: arm64: fsl: add Olimex i.MX8MP boards Zoltan HERPAI
2026-09-18 20:04 ` sashiko-bot
2026-09-19 7:11 ` Krzysztof Kozlowski
2026-09-18 19:55 ` [PATCH 2/2] arm64: dts: imx8mp: add Olimex i.MX8MP-SOM-EVB kit Zoltan HERPAI
2026-09-18 20:07 ` sashiko-bot
2026-09-19 7:10 ` Krzysztof Kozlowski [this message]
2026-09-20 15:04 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77606157-1d09-45a9-bf1c-b8c1d921cee3@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=wigyori@uid0.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.