From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 1/4 v2] drm/bridge: adv7511: Move the common data structures to header file Date: Tue, 30 Aug 2016 11:56:43 +0300 Message-ID: <7766481.8H4bRDdhqf@avalon> References: <1472514096-10915-1-git-send-email-john.stultz@linaro.org> <1472514096-10915-2-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id A84F76E36A for ; Tue, 30 Aug 2016 08:56:23 +0000 (UTC) In-Reply-To: <1472514096-10915-2-git-send-email-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: Guodong Xu , dri-devel@lists.freedesktop.org, lkml , Jose Abreu , Wolfram Sang , Mark Brown , Srinivas Kandagatla , Dave Long , Andy Green , Zhangfei Gao List-Id: dri-devel@lists.freedesktop.org SGkgSm9obiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gTW9uZGF5IDI5IEF1ZyAyMDE2 IDE2OjQxOjMzIEpvaG4gU3R1bHR6IHdyb3RlOgo+IEZyb206IEFyY2hpdCBUYW5lamEgPGFyY2hp dHRAY29kZWF1cm9yYS5vcmc+Cj4gCj4gVGhpcyBwYXRjaCBtb3ZlcyB0aGUgYWR2NzUxMSBkYXRh IHN0cnVjdHVyZSB0byBoZWFkZXIgZmlsZSBzbyB0aGF0IHRoZQo+IGF1ZGlvIGRyaXZlciBmaWxl IGNvdWxkIHVzZSBpdC4KCkFjdHVhbGx5IGl0IGRvZXNuJ3QsIHRoZSBkYXRhIHN0cnVjdHVyZSBp cyBhbHJlYWR5IGluIHRoZSBoZWFkZXIgZmlsZS4KCj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGll ZEBsaW51eC5pZT4KPiBDYzogQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBjb2RlYXVyb3JhLm9yZz4K PiBDYzogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29t Pgo+IENjOiBXb2xmcmFtIFNhbmcgPHdzYStyZW5lc2FzQHNhbmctZW5naW5lZXJpbmcuY29tPgo+ IENjOiBTcmluaXZhcyBLYW5kYWdhdGxhIDxzcmluaXZhcy5rYW5kYWdhdGxhQGxpbmFyby5vcmc+ Cj4gQ2M6ICJWaWxsZSBTeXJqw6Rsw6QiIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K PiBDYzogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AZnJlZS1lbGVjdHJvbnMuY29t Pgo+IENjOiBBbmR5IEdyZWVuIDxhbmR5QHdhcm1jYXQuY29tPgo+IENjOiBEYXZlIExvbmcgPGRh dmUubG9uZ0BsaW5hcm8ub3JnPgo+IENjOiBHdW9kb25nIFh1IDxndW9kb25nLnh1QGxpbmFyby5v cmc+Cj4gQ2M6IFpoYW5nZmVpIEdhbyA8emhhbmdmZWkuZ2FvQGxpbmFyby5vcmc+Cj4gQ2M6IE1h cmsgQnJvd24gPGJyb29uaWVAa2VybmVsLm9yZz4KPiBDYzogTGFycy1QZXRlciBDbGF1c2VuIDxs YXJzQG1ldGFmb28uZGU+Cj4gQ2M6IEpvc2UgQWJyZXUgPGpvYWJyZXVAc3lub3BzeXMuY29tPgo+ IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gU2lnbmVkLW9mZi1ieTogU3Jp bml2YXMgS2FuZGFnYXRsYSA8c3Jpbml2YXMua2FuZGFnYXRsYUBsaW5hcm8ub3JnPgo+IFNpZ25l ZC1vZmYtYnk6IEpvaG4gU3R1bHR6IDxqb2huLnN0dWx0ekBsaW5hcm8ub3JnPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMS5oICAgICB8IDggKysrKysrKysK PiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFfZHJ2LmMgfCA0ICsrLS0K PiAgMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMS5oCj4g Yi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMS5oIGluZGV4IDE2MWM5MjMu LmM3MDAyYTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fk djc1MTEuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExLmgK PiBAQCAtMTYsNiArMTYsMTQgQEAKPiAgI2luY2x1ZGUgPGRybS9kcm1fY3J0Y19oZWxwZXIuaD4K PiAgI2luY2x1ZGUgPGRybS9kcm1fbWlwaV9kc2kuaD4KPiAKPiArI2luY2x1ZGUgPGRybS9kcm1f Y3J0Y19oZWxwZXIuaD4KCklzbid0IGl0IGVub3VnaCB0byBpbmNsdWRlIHRoYXQgaGVhZGVyIG9u Y2UgPyA6LSkKCj4gKwo+ICtzdHJ1Y3QgcmVnbWFwOwoKVGhpcyBpc24ndCBuZWVkZWQsIHRoZSBo ZWFkZXIgaW5jbHVkZXMgbGludXgvcmVnbWFwLmguCgo+ICtzdHJ1Y3QgYWR2NzUxMTsKPiArCj4g K2ludCBhZHY3NTExX3BhY2tldF9lbmFibGUoc3RydWN0IGFkdjc1MTEgKmFkdjc1MTEsIHVuc2ln bmVkIGludCBwYWNrZXQpOwo+ICtpbnQgYWR2NzUxMV9wYWNrZXRfZGlzYWJsZShzdHJ1Y3QgYWR2 NzUxMSAqYWR2NzUxMSwgdW5zaWduZWQgaW50IHBhY2tldCk7CgpZb3UgY2FuIG1vdmUgdGhvc2Ug dHdvIGZ1bmN0aW9ucyBhdCB0aGUgZW5kLCB3aXRoIGFsbCB0aGUgb3RoZXIgZnVuY3Rpb24gCmRl Y2xhcmF0aW9ucywgYW5kIGdldCByaWQgb2YgdGhlIGZvcndhcmQgZGVjbGFyYXRpb24gb2Ygc3Ry dWN0IGFkdjc1MTEuCgo+ICAjZGVmaW5lIEFEVjc1MTFfUkVHX0NISVBfUkVWSVNJT04JCTB4MDAK PiAgI2RlZmluZSBBRFY3NTExX1JFR19OMAkJCQkweDAxCj4gICNkZWZpbmUgQURWNzUxMV9SRUdf TjEJCQkJMHgwMgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEv YWR2NzUxMV9kcnYuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFf ZHJ2LmMgaW5kZXggZWM4ZmIyZS4uZjhlYjdmOAo+IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFfZHJ2LmMKPiBAQCAtMTYwLDcgKzE2MCw3IEBAIHN0YXRp YyB2b2lkIGFkdjc1MTFfc2V0X2NvbG9ybWFwKHN0cnVjdCBhZHY3NTExCj4gKmFkdjc1MTEsIGJv b2wgZW5hYmxlLCBBRFY3NTExX0NTQ19VUERBVEVfTU9ERSwgMCk7Cj4gIH0KPiAKPiAtc3RhdGlj IGludCBhZHY3NTExX3BhY2tldF9lbmFibGUoc3RydWN0IGFkdjc1MTEgKmFkdjc1MTEsIHVuc2ln bmVkIGludAo+IHBhY2tldCkKPiAraW50IGFkdjc1MTFfcGFja2V0X2VuYWJsZShzdHJ1Y3QgYWR2 NzUxMSAqYWR2NzUxMSwgdW5zaWduZWQgaW50IHBhY2tldCkKPiAgewo+ICAJaWYgKHBhY2tldCAm IDB4ZmYpCj4gIAkJcmVnbWFwX3VwZGF0ZV9iaXRzKGFkdjc1MTEtPnJlZ21hcCwgCkFEVjc1MTFf UkVHX1BBQ0tFVF9FTkFCTEUwLAo+IEBAIC0xNzUsNyArMTc1LDcgQEAgc3RhdGljIGludCBhZHY3 NTExX3BhY2tldF9lbmFibGUoc3RydWN0IGFkdjc1MTEKPiAqYWR2NzUxMSwgdW5zaWduZWQgaW50 IHBhY2tldCkgcmV0dXJuIDA7Cj4gIH0KPiAKPiAtc3RhdGljIGludCBhZHY3NTExX3BhY2tldF9k aXNhYmxlKHN0cnVjdCBhZHY3NTExICphZHY3NTExLCB1bnNpZ25lZCBpbnQKPiBwYWNrZXQpCj4g K2ludCBhZHY3NTExX3BhY2tldF9kaXNhYmxlKHN0cnVjdCBhZHY3NTExICphZHY3NTExLCB1bnNp Z25lZCBpbnQgcGFja2V0KQo+ICB7Cj4gIAlpZiAocGFja2V0ICYgMHhmZikKPiAgCQlyZWdtYXBf dXBkYXRlX2JpdHMoYWR2NzUxMS0+cmVnbWFwLCAKQURWNzUxMV9SRUdfUEFDS0VUX0VOQUJMRTAs CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757482AbcH3I4r (ORCPT ); Tue, 30 Aug 2016 04:56:47 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:36232 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756753AbcH3I40 (ORCPT ); Tue, 30 Aug 2016 04:56:26 -0400 From: Laurent Pinchart To: John Stultz Cc: lkml , Archit Taneja , David Airlie , Wolfram Sang , Srinivas Kandagatla , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Boris Brezillon , Andy Green , Dave Long , Guodong Xu , Zhangfei Gao , Mark Brown , Lars-Peter Clausen , Jose Abreu , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/4 v2] drm/bridge: adv7511: Move the common data structures to header file Date: Tue, 30 Aug 2016 11:56:43 +0300 Message-ID: <7766481.8H4bRDdhqf@avalon> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.20; x86_64; ; ) In-Reply-To: <1472514096-10915-2-git-send-email-john.stultz@linaro.org> References: <1472514096-10915-1-git-send-email-john.stultz@linaro.org> <1472514096-10915-2-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u7U8uxXI027991 Hi John, Thank you for the patch. On Monday 29 Aug 2016 16:41:33 John Stultz wrote: > From: Archit Taneja > > This patch moves the adv7511 data structure to header file so that the > audio driver file could use it. Actually it doesn't, the data structure is already in the header file. > Cc: David Airlie > Cc: Archit Taneja > Cc: Laurent Pinchart > Cc: Wolfram Sang > Cc: Srinivas Kandagatla > Cc: "Ville Syrjälä" > Cc: Boris Brezillon > Cc: Andy Green > Cc: Dave Long > Cc: Guodong Xu > Cc: Zhangfei Gao > Cc: Mark Brown > Cc: Lars-Peter Clausen > Cc: Jose Abreu > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Srinivas Kandagatla > Signed-off-by: John Stultz > --- > drivers/gpu/drm/bridge/adv7511/adv7511.h | 8 ++++++++ > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 ++-- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h > b/drivers/gpu/drm/bridge/adv7511/adv7511.h index 161c923..c7002a0 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h > @@ -16,6 +16,14 @@ > #include > #include > > +#include Isn't it enough to include that header once ? :-) > + > +struct regmap; This isn't needed, the header includes linux/regmap.h. > +struct adv7511; > + > +int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet); > +int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet); You can move those two functions at the end, with all the other function declarations, and get rid of the forward declaration of struct adv7511. > #define ADV7511_REG_CHIP_REVISION 0x00 > #define ADV7511_REG_N0 0x01 > #define ADV7511_REG_N1 0x02 > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ec8fb2e..f8eb7f8 > 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -160,7 +160,7 @@ static void adv7511_set_colormap(struct adv7511 > *adv7511, bool enable, ADV7511_CSC_UPDATE_MODE, 0); > } > > -static int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int > packet) > +int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet) > { > if (packet & 0xff) > regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0, > @@ -175,7 +175,7 @@ static int adv7511_packet_enable(struct adv7511 > *adv7511, unsigned int packet) return 0; > } > > -static int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int > packet) > +int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet) > { > if (packet & 0xff) > regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0, -- Regards, Laurent Pinchart