From: Yi Liu <yi.l.liu@intel.com>
To: Baolu Lu <baolu.lu@linux.intel.com>, <joro@8bytes.org>,
<jgg@nvidia.com>, <kevin.tian@intel.com>
Cc: <alex.williamson@redhat.com>, <robin.murphy@arm.com>,
<eric.auger@redhat.com>, <nicolinc@nvidia.com>,
<kvm@vger.kernel.org>, <chao.p.peng@linux.intel.com>,
<iommu@lists.linux.dev>
Subject: Re: [PATCH 2/6] iommu/vt-d: Move intel_drain_pasid_prq() into intel_pasid_tear_down_entry()
Date: Fri, 28 Jun 2024 18:51:53 +0800 [thread overview]
Message-ID: <7785947b-3ff4-4c5d-93cc-cb54dcc0a5cd@intel.com> (raw)
In-Reply-To: <8e2bbc1a-f014-4fd9-bbb9-c6e5e47595f3@linux.intel.com>
On 2024/6/28 17:42, Baolu Lu wrote:
> On 2024/6/28 16:55, Yi Liu wrote:
>> Draining PRQ is needed before repurposing a PASID. It makes sense to invoke
>> it in the intel_pasid_tear_down_entry().
>
> Can you please elaborate on the value of this merge?
>
The major reason is that the next patch would have multiple places that
need to destroy pasid entry and do prq drain. Wrap them would make life
easier I suppose.
> Draining the PRQ is necessary when PRI is enabled on the device, and a
> page table is about to be removed from the PASID. This might occur in
> conjunction with tearing down a PASID entry, but it seems they are two
> distinct actions.
Seems like mostly they have conjunction, while there is indeed one
exception in the intel_mm_release(). Given the above reason, do you have
any suggestion for it?
--
Regards,
Yi Liu
next prev parent reply other threads:[~2024-06-28 10:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 8:55 [PATCH 0/6] Make set_dev_pasid op supportting domain replacement Yi Liu
2024-06-28 8:55 ` [PATCH 1/6] iommu: Pass old domain to set_dev_pasid op Yi Liu
2024-06-28 8:55 ` [PATCH 2/6] iommu/vt-d: Move intel_drain_pasid_prq() into intel_pasid_tear_down_entry() Yi Liu
2024-06-28 9:42 ` Baolu Lu
2024-06-28 10:51 ` Yi Liu [this message]
2024-07-10 8:25 ` Tian, Kevin
2024-06-28 8:55 ` [PATCH 3/6] iommu/vt-d: Make helpers support modifying present pasid entry Yi Liu
2024-06-28 9:52 ` Baolu Lu
2024-06-28 10:56 ` Yi Liu
2024-07-15 7:53 ` Tian, Kevin
2024-07-15 8:05 ` Yi Liu
2024-06-28 8:55 ` [PATCH 4/6] iommu/vt-d: Make intel_iommu_set_dev_pasid() to handle domain replacement Yi Liu
2024-07-15 7:58 ` Tian, Kevin
2024-06-28 8:55 ` [PATCH 5/6] iommu/vt-d: Add set_dev_pasid callback for nested domain Yi Liu
2024-06-28 8:55 ` [PATCH 6/6] iommu: Make set_dev_pasid op support domain replacement Yi Liu
2024-07-15 8:02 ` Tian, Kevin
2024-07-15 8:37 ` Yi Liu
2024-07-10 8:24 ` [PATCH 0/6] Make set_dev_pasid op supportting " Tian, Kevin
2024-07-11 18:41 ` Jason Gunthorpe
2024-07-15 8:16 ` Tian, Kevin
2024-07-15 12:19 ` Jason Gunthorpe
2024-07-15 8:23 ` Yi Liu
2024-07-15 12:19 ` Jason Gunthorpe
2024-07-16 2:07 ` Yi Liu
2024-07-11 18:37 ` Jason Gunthorpe
2024-07-15 8:11 ` Yi Liu
2024-07-15 12:16 ` Jason Gunthorpe
2024-08-15 17:49 ` Vasant Hegde
2024-08-16 1:19 ` Yi Liu
2024-08-16 2:49 ` Baolu Lu
2024-08-16 5:17 ` Vasant Hegde
2024-08-16 2:52 ` Baolu Lu
2024-08-16 6:08 ` Yi Liu
2024-08-16 5:19 ` Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7785947b-3ff4-4c5d-93cc-cb54dcc0a5cd@intel.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.