From: Balbir Singh <balbirs@nvidia.com>
To: Rik van Riel <riel@surriel.com>, Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
Nhat Pham <nphamcs@gmail.com>,
Yosry Ahmed <yosryahmed@google.com>
Subject: Re: [PATCH] memcg: allow exiting tasks to write back data to swap
Date: Fri, 13 Dec 2024 10:39:48 +1100 [thread overview]
Message-ID: <778ce6c8-9d77-4d85-9954-a930c5b84311@nvidia.com> (raw)
In-Reply-To: <06afcaa995425c3c8b743485c6374ad92934f5de.camel@surriel.com>
On 12/13/24 01:03, Rik van Riel wrote:
> On Thu, 2024-12-12 at 14:25 +1100, Balbir Singh wrote:
>>
>> I was asking about this change (this patch), I know that the return
>> true will help avoid the PAGE_ACTIVATE path, but I am not sure why
>> this function will return false if CONFIG_ZSWAP is enabled (unless
>> zswap_writeback is turned off in one of the groups)
>>
> Some workloads are fine with incurring the latency
> from zswap, but do not want the latency of actual
> block device backed swap.
>
> Having zswap enabled, with writeback disabled, has
> been beneficial to a number of workloads.
>
Thanks, that was the missing bit
Balbir
prev parent reply other threads:[~2024-12-12 23:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 15:53 [PATCH] memcg: allow exiting tasks to write back data to swap Rik van Riel
2024-12-11 16:26 ` Yosry Ahmed
2024-12-11 16:34 ` Rik van Riel
2024-12-11 17:00 ` Yosry Ahmed
2024-12-11 17:19 ` Rik van Riel
2024-12-11 17:30 ` Yosry Ahmed
2024-12-11 17:49 ` Rik van Riel
2024-12-11 23:15 ` Balbir Singh
2024-12-12 1:21 ` Rik van Riel
2024-12-12 3:25 ` Balbir Singh
2024-12-12 14:03 ` Rik van Riel
2024-12-12 23:39 ` Balbir Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=778ce6c8-9d77-4d85-9954-a930c5b84311@nvidia.com \
--to=balbirs@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=riel@surriel.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.