From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com,
David Hunt <david.hunt@intel.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH] eal/x86: fix segfaults in waitpkg power intrinsics
Date: Wed, 08 Nov 2023 16:15:41 +0100 [thread overview]
Message-ID: <7797250.gsGJI6kyIV@thomas> (raw)
In-Reply-To: <20231108031920.GA19492@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
08/11/2023 04:19, Tyler Retzlaff:
> On Tue, Nov 07, 2023 at 04:19:01PM +0000, Bruce Richardson wrote:
> > From: David Hunt <david.hunt@intel.com>
> >
> > The code was recently enhanced to allow the use of the waitpkg
> > intrinsics rather than the raw assembly in the rte_power functions.
> > However, the parameters to the intrinsics, while compiling fine, were
> > incorrect, and would segfault when run on the appropriate hardware.
> > This patch fixes the intrinsic parameters. Tested on a system with
> > tpause and umonitor/umwait instructions.
> >
> > Fixes: 60943c04f3bc ("eal/x86: use intrinsics for power management")
> >
> > Signed-off-by: David Hunt <david.hunt@intel.com>
> > Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.
prev parent reply other threads:[~2023-11-08 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 16:19 [PATCH] eal/x86: fix segfaults in waitpkg power intrinsics Bruce Richardson
2023-11-08 3:19 ` Tyler Retzlaff
2023-11-08 15:15 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7797250.gsGJI6kyIV@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.