From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6C8CB4038E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 8EE3F4041C MIME-Version: 1.0 Date: Thu, 20 Oct 2022 21:59:03 +0200 From: netdev@kapio-technology.com In-Reply-To: <20221020132538.reirrskemcjwih2m@skbuf> References: <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-11-netdev@kapio-technology.com> <20221018165619.134535-11-netdev@kapio-technology.com> <20221020132538.reirrskemcjwih2m@skbuf> Message-ID: <77c2b6507fd267cefdaf74e53c2bd325@kapio-technology.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v8 net-next 10/12] net: dsa: mv88e6xxx: mac-auth/MAB implementation List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Oltean Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , linux-kselftest@vger.kernel.org, Joachim Wiberg , Shuah Khan , Ivan Vecera , Florian Fainelli , Daniel Borkmann , Ido Schimmel , bridge@lists.linux-foundation.org, Russell King , linux-arm-kernel@lists.infradead.org, Roopa Prabhu , kuba@kernel.org, Paolo Abeni , Vivien Didelot , Woojung Huh , Landen Chao , Jiri Pirko , Amit Cohen , Christian Marangi , Hauke Mehrtens , Hans Schultz , Sean Wang , DENG Qingfang , Claudiu Manoil , linux-mediatek@lists.infradead.org, Matthias Brugger , Yuwei Wang , Petr Machata , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Florent Fourcot , UNGLinuxDriver@microchip.com, davem@davemloft.net On 2022-10-20 15:25, Vladimir Oltean wrote: >> + >> +#include >> +#include >> +#include "chip.h" >> +#include "global1.h" >> +#include "switchdev.h" >> + >> +static void mv88e6xxx_atu_locked_entry_purge(struct >> mv88e6xxx_atu_locked_entry *ale, >> + bool notify, bool take_nl_lock) >> +{ >> + struct switchdev_notifier_fdb_info info = { >> + .addr = ale->mac, >> + .vid = ale->vid, >> + .locked = true, >> + .offloaded = true, >> + }; >> + struct mv88e6xxx_atu_entry entry; >> + struct net_device *brport; >> + struct dsa_port *dp; >> + >> + entry.portvec = MV88E6XXX_G1_ATU_DATA_PORT_VECTOR_NO_EGRESS; >> + entry.state = MV88E6XXX_G1_ATU_DATA_STATE_UC_UNUSED; >> + entry.trunk = false; >> + ether_addr_copy(entry.mac, ale->mac); >> + >> + mv88e6xxx_reg_lock(ale->chip); >> + mv88e6xxx_g1_atu_loadpurge(ale->chip, ale->fid, &entry); >> + mv88e6xxx_reg_unlock(ale->chip); >> + >> + dp = dsa_to_port(ale->chip->ds, ale->port); >> + >> + if (notify) { >> + if (take_nl_lock) >> + rtnl_lock(); > > Is this tested with lockdep? I see the function is called with other > locks held (p->ale_list_lock). Isn't there a lock inversion anywhere? > Locks always need to be taken in the same order, and rtnl_lock is a > pretty high level lock, not exactly the kind you could take just like > that. > I am very sure that there is no lock inversions or double locks taken. It is only in the clean-up from time-out of driver locked entries that the nl lock needs to be taken (as the code reveals). In all other instances, the nl lock is already taken as far as this implementation goes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E603C433FE for ; Thu, 20 Oct 2022 19:59:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229845AbiJTT7H (ORCPT ); Thu, 20 Oct 2022 15:59:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229799AbiJTT7G (ORCPT ); Thu, 20 Oct 2022 15:59:06 -0400 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CD23213441; Thu, 20 Oct 2022 12:59:04 -0700 (PDT) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 896781884703; Thu, 20 Oct 2022 19:59:03 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 6B69E25001FA; Thu, 20 Oct 2022 19:59:03 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 62A2E9EC0002; Thu, 20 Oct 2022 19:59:03 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Thu, 20 Oct 2022 21:59:03 +0200 From: netdev@kapio-technology.com To: Vladimir Oltean Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Ido Schimmel , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v8 net-next 10/12] net: dsa: mv88e6xxx: mac-auth/MAB implementation In-Reply-To: <20221020132538.reirrskemcjwih2m@skbuf> References: <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-11-netdev@kapio-technology.com> <20221018165619.134535-11-netdev@kapio-technology.com> <20221020132538.reirrskemcjwih2m@skbuf> User-Agent: Gigahost Webmail Message-ID: <77c2b6507fd267cefdaf74e53c2bd325@kapio-technology.com> X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 2022-10-20 15:25, Vladimir Oltean wrote: >> + >> +#include >> +#include >> +#include "chip.h" >> +#include "global1.h" >> +#include "switchdev.h" >> + >> +static void mv88e6xxx_atu_locked_entry_purge(struct >> mv88e6xxx_atu_locked_entry *ale, >> + bool notify, bool take_nl_lock) >> +{ >> + struct switchdev_notifier_fdb_info info = { >> + .addr = ale->mac, >> + .vid = ale->vid, >> + .locked = true, >> + .offloaded = true, >> + }; >> + struct mv88e6xxx_atu_entry entry; >> + struct net_device *brport; >> + struct dsa_port *dp; >> + >> + entry.portvec = MV88E6XXX_G1_ATU_DATA_PORT_VECTOR_NO_EGRESS; >> + entry.state = MV88E6XXX_G1_ATU_DATA_STATE_UC_UNUSED; >> + entry.trunk = false; >> + ether_addr_copy(entry.mac, ale->mac); >> + >> + mv88e6xxx_reg_lock(ale->chip); >> + mv88e6xxx_g1_atu_loadpurge(ale->chip, ale->fid, &entry); >> + mv88e6xxx_reg_unlock(ale->chip); >> + >> + dp = dsa_to_port(ale->chip->ds, ale->port); >> + >> + if (notify) { >> + if (take_nl_lock) >> + rtnl_lock(); > > Is this tested with lockdep? I see the function is called with other > locks held (p->ale_list_lock). Isn't there a lock inversion anywhere? > Locks always need to be taken in the same order, and rtnl_lock is a > pretty high level lock, not exactly the kind you could take just like > that. > I am very sure that there is no lock inversions or double locks taken. It is only in the clean-up from time-out of driver locked entries that the nl lock needs to be taken (as the code reveals). In all other instances, the nl lock is already taken as far as this implementation goes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEBD0C4332F for ; Thu, 20 Oct 2022 20:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IvZikZ/02i2IEyIoRz4lTjbLRF7XaRk6qTq4iV55/KM=; b=w2IA8so0HgCaHCI9LkcbM9OvWY WGGSqu56NcCujBLc23NDdDno1kF/mYY4pWiJs3LZRjUOVaTCc1kqDK8lLdNaZXGp+vtlCx8ypSjim OotJTxbdz1r3QYV1PFMV1zj7btCL/kZPkeSxda7eB3ZYN8tzRQO2l/Kz7wSc+PhlXW79LFoCvY9T4 TkqwyE/BBpQLsGvIoEKvPDAC3nwxgL6/5SiEGitl8zb4W0ET5PPIRmLo7I7TPNVIZ5+GbFjfacQcg +Ekno1h8zQbA12qgsUZQ8odEAwakciZ0mhxuc8v30BuBVVvICUAnn85DPFeAQysiT47z1z+MvE9en WQK1ELeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olbh9-001YyZ-J9; Thu, 20 Oct 2022 19:59:11 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olbh6-001YwO-5f; Thu, 20 Oct 2022 19:59:09 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 896781884703; Thu, 20 Oct 2022 19:59:03 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 6B69E25001FA; Thu, 20 Oct 2022 19:59:03 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 62A2E9EC0002; Thu, 20 Oct 2022 19:59:03 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Thu, 20 Oct 2022 21:59:03 +0200 From: netdev@kapio-technology.com To: Vladimir Oltean Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Ido Schimmel , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v8 net-next 10/12] net: dsa: mv88e6xxx: mac-auth/MAB implementation In-Reply-To: <20221020132538.reirrskemcjwih2m@skbuf> References: <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-11-netdev@kapio-technology.com> <20221018165619.134535-11-netdev@kapio-technology.com> <20221020132538.reirrskemcjwih2m@skbuf> User-Agent: Gigahost Webmail Message-ID: <77c2b6507fd267cefdaf74e53c2bd325@kapio-technology.com> X-Sender: netdev@kapio-technology.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_125908_383793_BE66DD42 X-CRM114-Status: GOOD ( 13.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-10-20 15:25, Vladimir Oltean wrote: >> + >> +#include >> +#include >> +#include "chip.h" >> +#include "global1.h" >> +#include "switchdev.h" >> + >> +static void mv88e6xxx_atu_locked_entry_purge(struct >> mv88e6xxx_atu_locked_entry *ale, >> + bool notify, bool take_nl_lock) >> +{ >> + struct switchdev_notifier_fdb_info info = { >> + .addr = ale->mac, >> + .vid = ale->vid, >> + .locked = true, >> + .offloaded = true, >> + }; >> + struct mv88e6xxx_atu_entry entry; >> + struct net_device *brport; >> + struct dsa_port *dp; >> + >> + entry.portvec = MV88E6XXX_G1_ATU_DATA_PORT_VECTOR_NO_EGRESS; >> + entry.state = MV88E6XXX_G1_ATU_DATA_STATE_UC_UNUSED; >> + entry.trunk = false; >> + ether_addr_copy(entry.mac, ale->mac); >> + >> + mv88e6xxx_reg_lock(ale->chip); >> + mv88e6xxx_g1_atu_loadpurge(ale->chip, ale->fid, &entry); >> + mv88e6xxx_reg_unlock(ale->chip); >> + >> + dp = dsa_to_port(ale->chip->ds, ale->port); >> + >> + if (notify) { >> + if (take_nl_lock) >> + rtnl_lock(); > > Is this tested with lockdep? I see the function is called with other > locks held (p->ale_list_lock). Isn't there a lock inversion anywhere? > Locks always need to be taken in the same order, and rtnl_lock is a > pretty high level lock, not exactly the kind you could take just like > that. > I am very sure that there is no lock inversions or double locks taken. It is only in the clean-up from time-out of driver locked entries that the nl lock needs to be taken (as the code reveals). In all other instances, the nl lock is already taken as far as this implementation goes. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel