From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9530BC433F5 for ; Fri, 25 Feb 2022 20:54:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BE3E21F4C; Fri, 25 Feb 2022 21:53:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BE3E21F4C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1645822438; bh=BziXm4rG5o8ule2VC+9eGMOUEp2AQwa5pJwMHslO3vU=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=K986HLG+F2DxWMeJvwGjqepoJb64feBUpq4tJk+EeAHxCn6ODHqPFkxmoFl4P+xMo /5/mWwSHP7rpiYUglFvJUcaFgpXoyjDp347SDSkd6LrOSoh1OOB6q0tu6rC7sG6Msh StuhA3BSIVi5F1akJ5PNR0lQGIaKCJd9yUK8BrJU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 555ABF804FC; Fri, 25 Feb 2022 21:52:42 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1A965F8020D; Fri, 25 Feb 2022 21:52:35 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5485DF80132 for ; Fri, 25 Feb 2022 21:52:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5485DF80132 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MWDpOnQb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645822353; x=1677358353; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=BziXm4rG5o8ule2VC+9eGMOUEp2AQwa5pJwMHslO3vU=; b=MWDpOnQbSvDbTlEtWLdqLSDf7d1Iehhw7JNApsHEKmL/TLaIbekB50hs Kcpc6l/Pe8L+TfiOtaq6DFckCt2+d2oj46cxHex7SOK4FNgnbyqpbehOo 2i8E2d89dY+9Rtr0NZPHEwZbfgdkrHD1zN056Hx/muojs3kD1d27pakui 5inliSNW5EWDM0F8FehAgSJ1EhaQ5zeAmqpB+LHU9q5D5bZ6nhsz5Jsnb QT/yRqP3u3UB2bhWESDQb05iCXXrsYNqPjhY631EBz4kMq6Pz3lFHOpjw tWHW5aNb5piSAoeGBhkDbSClUXqUVy4bT6ADHEuvqQYn7qelz1B2Nb1jT g==; X-IronPort-AV: E=McAfee;i="6200,9189,10269"; a="313296121" X-IronPort-AV: E=Sophos;i="5.90,137,1643702400"; d="scan'208";a="313296121" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 12:52:28 -0800 X-IronPort-AV: E=Sophos;i="5.90,137,1643702400"; d="scan'208";a="777520530" Received: from nnwogbe-mobl1.amr.corp.intel.com (HELO [10.212.101.231]) ([10.212.101.231]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 12:52:27 -0800 Message-ID: <77ce39c4-b41d-88a9-b83e-e1ff3dc23584@linux.intel.com> Date: Fri, 25 Feb 2022 11:24:09 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Subject: Re: [RFC 03/13] ASoC: Intel: avs: Parse module-extension tuples Content-Language: en-US To: Cezary Rojewski , alsa-devel@alsa-project.org References: <20220207132532.3782412-1-cezary.rojewski@intel.com> <20220207132532.3782412-4-cezary.rojewski@intel.com> From: Pierre-Louis Bossart In-Reply-To: <20220207132532.3782412-4-cezary.rojewski@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: upstream@semihalf.com, harshapriya.n@intel.com, rad@semihalf.com, tiwai@suse.com, hdegoede@redhat.com, broonie@kernel.org, amadeuszx.slawinski@linux.intel.com, cujomalainey@chromium.org, lma@semihalf.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > +struct avs_tplg_modcfg_ext { > + guid_t type; > + > + union { > + struct { > + u16 num_input_pins; > + u16 num_output_pins; > + struct avs_tplg_pin_format *pin_fmts; > + } generic; > + struct { > + struct avs_audio_format *out_fmt; > + struct avs_audio_format *blob_fmt; /* optional override */ > + u32 feature_mask; > + union avs_virtual_index vindex; > + u32 dma_type; > + u32 dma_buffer_size; > + u32 config_length; > + /* config_data part of priv data */ > + } copier; > + struct { > + u32 out_channel_config; > + u32 coefficients_select; > + s32 coefficients[AVS_CHANNELS_MAX]; > + u32 channel_map; > + } updown_mix; > + struct { > + u32 out_freq; > + } src; > + struct { > + u32 out_freq; > + u8 mode; > + u8 disable_jitter_buffer; > + } asrc; > + struct { > + u32 cpc_lp_mode; > + } wov; > + struct { > + struct avs_audio_format *ref_fmt; > + struct avs_audio_format *out_fmt; > + u32 cpc_lp_mode; > + } aec; > + struct { > + struct avs_audio_format *ref_fmt; > + struct avs_audio_format *out_fmt; > + } mux; > + struct { > + struct avs_audio_format *out_fmt; > + } micsel; > + }; > +}; I am struggling to reconcile the notion of 'extension' with a fixed structure that deals with Intel-specific modules. How would a 3rd party add their own modules and expose parameters/tokens through the topology?