From: Ping-Ke Shih <pkshih@realtek.com>
To: kernel test robot <lkp@intel.com>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>
Subject: RE: [PATCH v2] wifi: rtw88: Add support for LED blinking
Date: Mon, 6 Jan 2025 03:32:22 +0000 [thread overview]
Message-ID: <77d348b8149b4d93bfbe86108941ba07@realtek.com> (raw)
In-Reply-To: <202501061046.U1iOSkRv-lkp@intel.com>
kernel test robot <lkp@intel.com> wrote:
>
> Hi Bitterblue,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on wireless-next/main]
> [also build test ERROR on wireless/main linus/master v6.13-rc6 next-20241220]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/linux/commits/Bitterblue-Smith/wifi-rtw88-Add-support-for-LED-blinkin
> g/20250106-030830
> base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
> patch link: https://lore.kernel.org/r/57c7d192-97ee-4da1-87a8-f040e9b8e3d1%40gmail.com
> patch subject: [PATCH v2] wifi: rtw88: Add support for LED blinking
> config: sh-allmodconfig
> (https://download.01.org/0day-ci/archive/20250106/202501061046.U1iOSkRv-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build):
> (https://download.01.org/0day-ci/archive/20250106/202501061046.U1iOSkRv-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202501061046.U1iOSkRv-lkp@intel.com/
>
> All error/warnings (new ones prefixed by >>):
>
> >> drivers/net/wireless/realtek/rtw88/led.c:19:6: error: redefinition of 'rtw_led_init'
> 19 | void rtw_led_init(struct rtw_dev *rtwdev)
> | ^~~~~~~~~~~~
As led.c is built, CONFIG_LEDS_CLASS=y in Makefile.
> In file included from drivers/net/wireless/realtek/rtw88/led.c:7:
> drivers/net/wireless/realtek/rtw88/led.h:15:13: note: previous definition of 'rtw_led_init' with type
> 'void(struct rtw_dev *)'
> 15 | static void rtw_led_init(struct rtw_dev *rtwdev)
> | ^~~~~~~~~~~~
However, weirdly CONFIG_LEDS_CLASS isn't defined in led.h.
By the way, my local build with selected CONFIG_LEDS_CLASS is fine.
prev parent reply other threads:[~2025-01-06 3:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 19:07 [PATCH v2] wifi: rtw88: Add support for LED blinking Bitterblue Smith
2025-01-06 1:19 ` Ping-Ke Shih
2025-01-06 2:37 ` kernel test robot
2025-01-06 3:32 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77d348b8149b4d93bfbe86108941ba07@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.