From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90906C021A9 for ; Mon, 17 Feb 2025 16:31:12 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.890683.1299819 (Exim 4.92) (envelope-from ) id 1tk41Q-0007mv-5f; Mon, 17 Feb 2025 16:31:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 890683.1299819; Mon, 17 Feb 2025 16:31:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tk41Q-0007mo-1i; Mon, 17 Feb 2025 16:31:04 +0000 Received: by outflank-mailman (input) for mailman id 890683; Mon, 17 Feb 2025 16:31:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tk41O-0007l1-H7 for xen-devel@lists.xenproject.org; Mon, 17 Feb 2025 16:31:02 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9330c8c9-ed4c-11ef-9aa6-95dc52dad729; Mon, 17 Feb 2025 17:31:01 +0100 (CET) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5e04cb346eeso3077707a12.2 for ; Mon, 17 Feb 2025 08:31:01 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aba5323202dsm903093266b.6.2025.02.17.08.31.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Feb 2025 08:31:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9330c8c9-ed4c-11ef-9aa6-95dc52dad729 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1739809861; x=1740414661; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=mQ2IeoO+WiJD99KVpVcsiVOIBnIP72sXFe1+iuF2U88=; b=emTLeHDdWL7wuGy+d8aqsuMw3C9+169f+Nqa//wjrHKCHLoUn7+WconLkD3tTjZsnR PKZnX9c/bq/Je1oz0BqqKGQLw0mCJusxYqoiO4RgFC/Yx57MIV+FY7PMyHYFrjl/xz22 y4+cSGhpGbua+G6sgQS+7NX8Xn7k237GN4jpzEA6bo1CLYUeZzATfTLqcKNBxvtm9OkD pEMbA1dz12xVKr7PBWBuzoF56z2CYNMM0uNAgmzY/ZEVHfG0xdUxr+A2ox2QzLICK1SD PAapZwatrvvFjW4JKLs0vvwpmMICtcwYxJnBPJ2wh0lHHAUZ713v/6nTN97RJ8gEWibE 9CLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739809861; x=1740414661; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mQ2IeoO+WiJD99KVpVcsiVOIBnIP72sXFe1+iuF2U88=; b=PeGN9YXrBJj/zU0o9LTwGrvH9ZdAS7YdtY1vcTSDEBk5MnP5tRIYJLWhQAxCBN1ZgB t37vWu8TaxzKkvlAwpFOhefawkIVephRDfFYoYuNuCZcYiKxO5sj3TlDjhXqFyW5PuAX zWvM3o1W7Zhf+Jv0JqOsoF0rjeKPhBkhHF6N5DT2MYEo0TEippXknhvdLk5HUpP5XR49 kOtNsWB/T9RQ8L3iMuQv86SYg7XoLdIpy+UoYYm5y2IEtu1/L/3NlxHDzgtkyPs+Wdo3 khqMsZppbyI6HcGI+MbYLHYKssEuQti/36zcxDxIfRfEGQElkJqmqHYE7gmUZNK5pC6L DRDA== X-Forwarded-Encrypted: i=1; AJvYcCWAX9OY8NzREtzcIYZkMbGQayskdKQcHGO6PqbiA6rlsdDM1R9B4mko+KaIGA9hFJ98mO5ierm1mW0=@lists.xenproject.org X-Gm-Message-State: AOJu0YzGZvDzDbewB6Iul1ZdRXSnctUKrY6UcCACNQGlCjKYH7tFyFd2 YaXZmcxIEW8g2Gz/Qtb5MskvCfTDP0iYP9d7vwI6LIwgvVSRzLJ1yvVWjILDIKKrbLLfXsSTi5Y = X-Gm-Gg: ASbGnctWi7zagDVejadh1guoGcUdZgRRcZsnTu5vr/CVjFdHBFHCAdsBFlFnp9irw2i qz9i5GYDjjk9ALiV8e9Mjs2bgtdENzzogtpWzckH0Sd9h7OeQqlPoEMJAY2eYe9HLc/FVaAAvdh 5iGqHaug8LLyAlh8+xUaoJl8h3Zy67EJ5lrpT18pOvrfwOWpDaqSoJAWf+lrvOLRc9kfHh+q8z2 qZ6qYqQudWs3Yq+Hd20uVMZos6eH9jfC+/2JVIP7c9o3QiopTtZMflk1Zj7GKAw5FD5y/nb2dz+ f4lNAb7x1LohHDcRoz3no8SDk7enweFeMXDCK7lmjJPWgLwKAlzOJm6Xe3xrm2WMslqwYelncVV K X-Google-Smtp-Source: AGHT+IGysohYYbQO+Nwqn9uMLSNZbM2fhXDFhJ5OW7Il9JXOJyFBZIUuC2IEXGXvtmcqCGS8rHuS+w== X-Received: by 2002:a17:907:3e02:b0:ab6:d4d0:2be9 with SMTP id a640c23a62f3a-abb70e67725mr1137594666b.56.1739809861002; Mon, 17 Feb 2025 08:31:01 -0800 (PST) Message-ID: <77eb149c-bb1e-4f77-85ba-c44b173a5c1e@suse.com> Date: Mon, 17 Feb 2025 17:31:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] Avoid crash calling PrintErrMesg from efi_multiboot2 To: Frediano Ziglio Cc: "Daniel P. Smith" , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org References: <20250217162659.151232-1-frediano.ziglio@cloud.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20250217162659.151232-1-frediano.ziglio@cloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17.02.2025 17:26, Frediano Ziglio wrote: > --- a/xen/common/efi/efi-common.mk > +++ b/xen/common/efi/efi-common.mk > @@ -2,6 +2,7 @@ EFIOBJ-y := boot.init.o pe.init.o ebmalloc.o runtime.o > EFIOBJ-$(CONFIG_COMPAT) += compat.o > > CFLAGS-y += -fshort-wchar > +CFLAGS-y += -fno-jump-tables > CFLAGS-y += -iquote $(srctree)/common/efi > CFLAGS-y += -iquote $(srcdir) Do source files other than boot.c really need this? Do any other files outside of efi/ maybe also need this (iirc this point was made along with the v5 comment you got)? Jan