From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1klEoB-0000kA-FE for mharc-grub-devel@gnu.org; Fri, 04 Dec 2020 12:23:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klEjt-00007N-O7 for grub-devel@gnu.org; Fri, 04 Dec 2020 12:19:42 -0500 Received: from mail-il1-x143.google.com ([2607:f8b0:4864:20::143]:34465) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klEjF-0000mA-D7 for grub-devel@gnu.org; Fri, 04 Dec 2020 12:19:08 -0500 Received: by mail-il1-x143.google.com with SMTP id x15so5878996ilq.1 for ; Fri, 04 Dec 2020 09:16:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Vqc00IuICMrzt8mF9k7kaP8pdRhG4dohUQmXTF4tGcI=; b=wit6mYe7D+AN2A1+TCgWPan4xe0h5x+FBrNY+VIgekr7Wf9dfeFT0lf7WyoTL5F3B2 MgjaMUCQq4shGqfkE/RkxQe401UIi7r5nDO/DmkJojx3YXDHwxgjPFLcO7xfmtlyHAlL SXAG+r4T7LVD1Jk8RNcjnTRkAEoUyF1dOLfI7yaVSQaWcQI4yp/hX7ju9W4qCSqGFmJX dEv7l0JLVEP/rPW6qwM9rTM9K6SGPL4wgdcqD0PjxDbrFFIMkmBH9yxW5gc8vKAnYXa5 w9tMq2BoHFZjVpj5e2dPrALtq5oU0BAye0WTsB0nzqxKk2dJFyuBggtJjOpyFHkbKREl 37qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Vqc00IuICMrzt8mF9k7kaP8pdRhG4dohUQmXTF4tGcI=; b=k+UQKLhtrEJyH1gcE+d2Nmdytyzjtkp7iRSo/df90zaOU0vOgy6lzR/gfO5nhaMH+f sPPRXRwjeoAAxrsim8eknZ+6FilhIslGfsKE3ixMTGzKeVks5gsM7rmaErS1/BuhXN8U HDEmRXd48thURFAg50rYnuf7gkjNkZo5UBMn08S0eteojpaXVLgREZpvyzKqJfZs9zA4 Wi7OzR99Dt5JDB91ThiDPdSxa2azdUup5n5JQbwItl2HxwkiqHArcExRQIfevfOAXk0Z s/gTK8qADPxfAX3MFksiEx38Zx88Bq6/n3bv7v7j+XCVW01YLTIA2Eqz9MHWCyxujcYP dxtA== X-Gm-Message-State: AOAM532ba51FyAN/WUkHKHSi5jSwnAWCsPjrQiKd4oC7s9q/7jPcrsk8 C79lAWcCd60maYWlKLNbApEDRUkbC7BGcg== X-Google-Smtp-Source: ABdhPJw+32ILvSveLDpdt4h7BT9xy8Ets+DaMabdtXntZPJi9mJui0P8wmM7RVEnJU1aA/aX2hdDbw== X-Received: by 2002:a92:6403:: with SMTP id y3mr7668925ilb.72.1607100253012; Fri, 04 Dec 2020 08:44:13 -0800 (PST) Received: from localhost.localdomain ([136.49.211.192]) by smtp.gmail.com with ESMTPSA id w3sm1754909iol.9.2020.12.04.08.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 08:44:12 -0800 (PST) From: Glenn Washburn To: grub-devel@gnu.org Cc: Patrick Steinhardt , Daniel Kiper , Glenn Washburn Subject: [PATCH v7 02/17] misc: Add parentheses around ALIGN_UP and ALIGN_DOWN arguments Date: Fri, 4 Dec 2020 10:43:31 -0600 Message-Id: <77f9671d5ddaffd454e2d7272f21b434fd2212fb.1607098915.git.development@efficientek.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::143; envelope-from=development@efficientek.com; helo=mail-il1-x143.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2020 17:20:07 -0000 X-List-Received-Date: Fri, 04 Dec 2020 17:20:07 -0000 This ensures that expected order of operations is preserved when arguments are expressions. Signed-off-by: Glenn Washburn --- include/grub/misc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/grub/misc.h b/include/grub/misc.h index b7ca6dd58..780a34e90 100644 --- a/include/grub/misc.h +++ b/include/grub/misc.h @@ -28,10 +28,10 @@ #include #define ALIGN_UP(addr, align) \ - ((addr + (typeof (addr)) align - 1) & ~((typeof (addr)) align - 1)) + (((addr) + (typeof (addr)) (align) - 1) & ~((typeof (addr)) (align) - 1)) #define ALIGN_UP_OVERHEAD(addr, align) ((-(addr)) & ((typeof (addr)) (align) - 1)) #define ALIGN_DOWN(addr, align) \ - ((addr) & ~((typeof (addr)) align - 1)) + ((addr) & ~((typeof (addr)) (align) - 1)) #define ARRAY_SIZE(array) (sizeof (array) / sizeof (array[0])) #define COMPILE_TIME_ASSERT(cond) switch (0) { case 1: case !(cond): ; } -- 2.27.0