From: Eric Blake <eblake@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Laurent Vivier <lvivier@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
Artyom Tarasenko <atar4qemu@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] hw/char: remove legacy interface escc_init()
Date: Fri, 19 Jan 2018 08:39:33 -0600 [thread overview]
Message-ID: <780c8da7-0a5a-4e00-fdbe-fd99f2ddab06@redhat.com> (raw)
In-Reply-To: <445b8b3e-1394-8cdc-ae20-e14cac32c5fa@ilande.co.uk>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
On 01/19/2018 06:47 AM, Mark Cave-Ayland wrote:
> On 18/01/18 08:53, Laurent Vivier wrote:
>> Move necessary stuff in escc.h and update type names.
>> Remove slavio_serial_ms_kbd_init().
>> Fix code style problems reported by checkpatch.pl
>> Update mac_newworld, mac_oldworld and sun4m to use directly the
>> QDEV interface.
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> ---
>> hw/char/escc.c | 208
>> -static inline void set_rxint(ChannelState *s)
>> +static inline void set_rxint(ESCCChannelState *s)
>> {
>> s->rxint = 1;
>> - /* XXX: missing daisy chainnig: chn_b rx should have a lower
>> priority
>> + /* XXX: missing daisy chainnig: escc_chn_b rx should have a lower
>> priority
As long as you are touching this, s/chainnig/chaining/
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
prev parent reply other threads:[~2018-01-19 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 8:53 [Qemu-devel] [PATCH] hw/char: remove legacy interface escc_init() Laurent Vivier
2018-01-19 12:20 ` Philippe Mathieu-Daudé
2018-01-19 12:47 ` Mark Cave-Ayland
2018-01-19 14:39 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=780c8da7-0a5a-4e00-fdbe-fd99f2ddab06@redhat.com \
--to=eblake@redhat.com \
--cc=agraf@suse.de \
--cc=atar4qemu@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.