From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE19C76196 for ; Wed, 29 Mar 2023 02:39:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbjC2CjW (ORCPT ); Tue, 28 Mar 2023 22:39:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229966AbjC2CjS (ORCPT ); Tue, 28 Mar 2023 22:39:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B4F73C21; Tue, 28 Mar 2023 19:39:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C5C2FB81E4A; Wed, 29 Mar 2023 02:39:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 838EAC433D2; Wed, 29 Mar 2023 02:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680057546; bh=X0dhzLuUJ5cHqjst/sBdQo/tR2QcJ8NyxEBS4h6WxQo=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=r189eUhMU6DgnM+c1XZBTEbSW6KfMfVZl3o1XtgZLZf5VKdz2bJEvEy4/U0sXOS8M joR/gtDmZulwepIqN5ll+nMdUw/hZxMdwP4UpYHASxCZ1MkBOjTxob/TNDaAJ0/NZW VJFcZEoJSNV6ZdWSUwYUzcFkpnxSXErrkeJ4MrcgPdQCB7B2wTUUSqOZjW758XNhpa y0Wt5OCVvyLyKI9jFz7VCvG/+PSwukfwelwk/45rz/lVDHeLaXtSgfrcMKKlW08t2y WJNXlDCVR9IXyXZpX9bQRsiC5fTEgajaxzPsVUIWp1ywNEoS8Wm9kZM3pur4XZMl/Q HJ3w1kXZGOXoA== Message-ID: <780d70173beb315695cedac6c6eafceb.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230312161512.2715500-19-u.kleine-koenig@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-19-u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH 18/30] clk: keystone: Convert to platform remove callback returning void From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org To: Michael Turquette , Nishanth Menon , Santosh Shilimkar , Tero Kristo , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Tue, 28 Mar 2023 19:39:04 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Uwe Kleine-K=C3=B6nig (2023-03-12 09:15:00) > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. >=20 > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- Applied to clk-next From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E75A0C76196 for ; Wed, 29 Mar 2023 02:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zh8HxZDwhPY0MvefGHeovopcUqHa6b0vBxda4BWZMao=; b=Wi4vlD0ILheDCg ONTeaptzKGCjooF7DjZ72Iulyg4AEHHGET36z7U6mo8M36flglZQrj3x0lA5Q4pWYrsMQvXdaYbEo trFk1F5jdTO3PclnIvJ0nUULMfR1QOaH4zhKwLAfI2kbwjGfgUToptoFxcEfmTr/uWuTZBTiWOUh/ e5OxqjI/V3sh5k/QjVyFb3k/WeF7v+zCKVg2uiRVB9CyUpaN36ImbzgkyPh0ZrnMDf4pHJxEbJPyn u1CYmj9rKFm6GOLB2Mw34U14r8yaFc0HZDBqV32EAG0uoaQWttD/FBQkBKBu7LFe38msMl9zC2JmZ BIJ+raN/5gG+UY5+kEgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phLiS-00GMpI-1h; Wed, 29 Mar 2023 02:39:12 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phLiP-00GMnj-1S for linux-arm-kernel@lists.infradead.org; Wed, 29 Mar 2023 02:39:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CB9CAB81F88; Wed, 29 Mar 2023 02:39:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 838EAC433D2; Wed, 29 Mar 2023 02:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680057546; bh=X0dhzLuUJ5cHqjst/sBdQo/tR2QcJ8NyxEBS4h6WxQo=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=r189eUhMU6DgnM+c1XZBTEbSW6KfMfVZl3o1XtgZLZf5VKdz2bJEvEy4/U0sXOS8M joR/gtDmZulwepIqN5ll+nMdUw/hZxMdwP4UpYHASxCZ1MkBOjTxob/TNDaAJ0/NZW VJFcZEoJSNV6ZdWSUwYUzcFkpnxSXErrkeJ4MrcgPdQCB7B2wTUUSqOZjW758XNhpa y0Wt5OCVvyLyKI9jFz7VCvG/+PSwukfwelwk/45rz/lVDHeLaXtSgfrcMKKlW08t2y WJNXlDCVR9IXyXZpX9bQRsiC5fTEgajaxzPsVUIWp1ywNEoS8Wm9kZM3pur4XZMl/Q HJ3w1kXZGOXoA== Message-ID: <780d70173beb315695cedac6c6eafceb.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230312161512.2715500-19-u.kleine-koenig@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-19-u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH 18/30] clk: keystone: Convert to platform remove callback returning void From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org To: Michael Turquette , Nishanth Menon , Santosh Shilimkar , Tero Kristo , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Tue, 28 Mar 2023 19:39:04 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_193909_648397_B94C809A X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UXVvdGluZyBVd2UgS2xlaW5lLUvDtm5pZyAoMjAyMy0wMy0xMiAwOToxNTowMCkKPiBUaGUgLnJl bW92ZSgpIGNhbGxiYWNrIGZvciBhIHBsYXRmb3JtIGRyaXZlciByZXR1cm5zIGFuIGludCB3aGlj aCBtYWtlcwo+IG1hbnkgZHJpdmVyIGF1dGhvcnMgd3JvbmdseSBhc3N1bWUgaXQncyBwb3NzaWJs ZSB0byBkbyBlcnJvciBoYW5kbGluZyBieQo+IHJldHVybmluZyBhbiBlcnJvciBjb2RlLiBIb3dl dmVyIHRoZSB2YWx1ZSByZXR1cm5lZCBpcyAobW9zdGx5KSBpZ25vcmVkCj4gYW5kIHRoaXMgdHlw aWNhbGx5IHJlc3VsdHMgaW4gcmVzb3VyY2UgbGVha3MuIFRvIGltcHJvdmUgaGVyZSB0aGVyZSBp cyBhCj4gcXVlc3QgdG8gbWFrZSB0aGUgcmVtb3ZlIGNhbGxiYWNrIHJldHVybiB2b2lkLiBJbiB0 aGUgZmlyc3Qgc3RlcCBvZiB0aGlzCj4gcXVlc3QgYWxsIGRyaXZlcnMgYXJlIGNvbnZlcnRlZCB0 byAucmVtb3ZlX25ldygpIHdoaWNoIGFscmVhZHkgcmV0dXJucwo+IHZvaWQuCj4gCj4gVHJpdmlh bGx5IGNvbnZlcnQgdGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhl IHJlbW92ZQo+IGNhbGxiYWNrIHRvIHRoZSB2b2lkIHJldHVybmluZyB2YXJpYW50Lgo+IAo+IFNp Z25lZC1vZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9u aXguZGU+Cj4gLS0tCgpBcHBsaWVkIHRvIGNsay1uZXh0CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==