From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Robert Yang <liezhi.yang@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 13/23] package_manager.py: reverse archs correctly
Date: Mon, 13 Nov 2017 13:15:46 +0200 [thread overview]
Message-ID: <780ec511-d488-0548-e1a9-e2c64a20385d@linux.intel.com> (raw)
In-Reply-To: <74e96cef-3591-da4a-93b1-e74ea4b0460e@windriver.com>
On 11/13/2017 12:23 PM, Robert Yang wrote:
>
>
> On 11/13/2017 05:04 PM, Alexander Kanavin wrote:
>> On 11/13/2017 10:40 AM, Robert Yang wrote:
>>>> Can you place all of this in a helper function please?
>>>
>>> Thanks, updated in the repo:
>>> + self._arch_reverse_helper()
>>
>> Don't make the helper update class variables. It makes the code hard
>> to understand or reason about. Instead, call like this:
>>
>> self.archs = _determine_archs(arch_var)
>>
>> and do the rest in the helper. So that self.archs is assigned to only
>> once.
>
> Thanks, updated in the repo:
Looks good now, thank you.
Alex
next prev parent reply other threads:[~2017-11-13 11:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 6:27 [PATCH 00/23] Fixes for multilib and eSDK Robert Yang
2017-11-10 6:27 ` [PATCH 01/23] staging.bbclass: make subprocess.check_output() capture stderr Robert Yang
2017-11-10 6:27 ` [PATCH 02/23] testsdk.bbclass: add a newline after own-mirrors Robert Yang
2017-11-10 6:27 ` [PATCH 03/23] populate_sdk_ext.bbclass: don't rename layers when failed Robert Yang
2017-11-10 6:27 ` [PATCH 04/23] oe/copy_buildsystem.py: make sure layer exists Robert Yang
2017-11-10 6:27 ` [PATCH 05/23] staging.bbclass: fix for multilib Robert Yang
2017-11-10 6:27 ` [PATCH 06/23] populate_sdk_ext.bbclass: " Robert Yang
2017-11-10 6:27 ` [PATCH 07/23] sstate.bbclass: sstate_hardcode_path(): " Robert Yang
2017-11-10 6:27 ` [PATCH 08/23] staging.bbclass: staging_populate_sysroot_dir(): " Robert Yang
2017-11-10 6:27 ` [PATCH 09/23] staging.bbclass: print searched manifest when not found Robert Yang
2017-11-20 19:58 ` Randy MacLeod
2017-11-21 1:26 ` Robert Yang
2017-11-21 2:26 ` Randy MacLeod
2017-11-21 2:42 ` Robert Yang
2017-11-10 6:27 ` [PATCH 10/23] staging.bbclass: extend_recipe_sysroot(): search multilib manifest Robert Yang
2017-11-10 6:27 ` [PATCH 11/23] image.bbclass: remove depmodwrapper-cross from DEPENDS Robert Yang
2017-11-10 6:27 ` [PATCH 12/23] package_manager.py: print running dnf command Robert Yang
2017-11-10 6:27 ` [PATCH 13/23] package_manager.py: reverse archs correctly Robert Yang
2017-11-10 14:21 ` Alexander Kanavin
2017-11-13 8:40 ` Robert Yang
2017-11-13 9:04 ` Alexander Kanavin
2017-11-13 10:23 ` Robert Yang
2017-11-13 11:15 ` Alexander Kanavin [this message]
2017-11-10 6:27 ` [PATCH 14/23] package_manager.py: remove obsolete MULTILIB_ARCHS Robert Yang
2017-11-10 6:27 ` [PATCH 15/23] multilib.bbclass: remove unneeded bb.data.inherits_class() Robert Yang
2017-11-10 6:27 ` [PATCH 16/23] multilib.bbclass: remove obsolete DEFAULTTUNE_ML_ Robert Yang
2017-11-10 6:27 ` [PATCH 17/23] multilib.bbclass: remove invalid PACKAGE_INSTALL Robert Yang
2017-11-10 6:27 ` [PATCH 18/23] multilib_global.bbclass: fix indent Robert Yang
2017-11-10 6:27 ` [PATCH 19/23] volatile-binds: use PN to replace hardcode name Robert Yang
2017-11-10 6:27 ` [PATCH 20/23] multilib.bbclass: extend allarch recipes Robert Yang
2017-11-10 6:27 ` [PATCH 21/23] toolchain-scripts.bbclass: only install all MULTILIB_VARIANTS for image Robert Yang
2017-11-10 6:27 ` [PATCH 22/23] populate_sdk_ext.bbclass: disable for multilib image Robert Yang
2017-11-10 6:27 ` [PATCH 23/23] populate_sdk_ext.bbclass: remove the try...finally Robert Yang
2017-11-10 13:34 ` [PATCH 00/23] Fixes for multilib and eSDK Robert Yang
2017-11-20 7:36 ` Robert Yang
2017-11-20 8:25 ` Richard Purdie
2017-11-20 8:48 ` Robert Yang
2017-12-26 2:25 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=780ec511-d488-0548-e1a9-e2c64a20385d@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.