From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from motgate8.mot.com (motgate8.mot.com [129.188.136.8]) by ozlabs.org (Postfix) with ESMTP id 7A73A2BF2E for ; Wed, 10 Nov 2004 01:27:41 +1100 (EST) In-Reply-To: References: Mime-Version: 1.0 (Apple Message framework v619) Content-Type: text/plain; charset=ISO-8859-1; format=flowed Message-Id: <781C4866-325B-11D9-AD97-000393DBC2E8@freescale.com> From: Kumar Gala Date: Tue, 9 Nov 2004 08:27:22 -0600 To: "Geert Uytterhoeven" Cc: Andrew Morton , Linux/PPC Development , Paul Mackerras , Kumar Gala , Linux Kernel Development Subject: Re: [PATCH][PPC32] Add performance counters to cpu_spec List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Nov 9, 2004, at 3:13 AM, Geert Uytterhoeven wrote: > On Mon, 8 Nov 2004, Kumar Gala wrote: > > Adds the number of performance monitor counters each PowerPC=20 > processor has to > > the cpu table.=A0 Makes oprofile support a bit cleaner since we = dont=20 > need a case > > statement on processor version to determine the number of counters. > > > > Signed-off-by: Kumar Gala > > > > -- > > > > diff -Nru a/arch/ppc/kernel/cputable.c b/arch/ppc/kernel/cputable.c > > --- a/arch/ppc/kernel/cputable.c=A0=A0=A0=A0=A0 2004-11-08 21:02:51 = -06:00 > > +++ b/arch/ppc/kernel/cputable.c=A0=A0=A0=A0=A0 2004-11-08 21:02:51 = -06:00 > > @@ -82,6 +82,7 @@ > >=A0 =A0=A0=A0=A0 CPU_FTR_601 | CPU_FTR_HPTE_TABLE, > >=A0 =A0=A0=A0=A0 COMMON_PPC | PPC_FEATURE_601_INSTR | = PPC_FEATURE_UNIFIED_CACHE, > >=A0 =A0=A0=A0=A0 32, 32, > > +=A0=A0=A0=A0 0, > >=A0 =A0=A0=A0=A0 __setup_cpu_601 > >=A0=A0=A0=A0=A0 }, > >=A0=A0=A0=A0=A0 {=A0=A0=A0=A0=A0=A0=A0 /* 603 */ > > Perhaps you want to switch to C99-style struct initialization as well? I can change it C99-style as well as fixing the formatting, just wanted=20= to see if there we any other comments. Will resend with those changes=20= if I dont hear any other feedback. - kumar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261516AbUKIO15 (ORCPT ); Tue, 9 Nov 2004 09:27:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261518AbUKIO14 (ORCPT ); Tue, 9 Nov 2004 09:27:56 -0500 Received: from motgate8.mot.com ([129.188.136.8]:12981 "EHLO motgate8.mot.com") by vger.kernel.org with ESMTP id S261516AbUKIO1y convert rfc822-to-8bit (ORCPT ); Tue, 9 Nov 2004 09:27:54 -0500 In-Reply-To: References: Mime-Version: 1.0 (Apple Message framework v619) Content-Type: text/plain; charset=ISO-8859-1; format=flowed Message-Id: <781C4866-325B-11D9-AD97-000393DBC2E8@freescale.com> Content-Transfer-Encoding: 8BIT Cc: "Paul Mackerras" , "Andrew Morton" , "Linux/PPC Development" , "Kumar Gala" , "Linux Kernel Development" From: Kumar Gala Subject: Re: [PATCH][PPC32] Add performance counters to cpu_spec Date: Tue, 9 Nov 2004 08:27:22 -0600 To: "Geert Uytterhoeven" X-Mailer: Apple Mail (2.619) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Nov 9, 2004, at 3:13 AM, Geert Uytterhoeven wrote: > On Mon, 8 Nov 2004, Kumar Gala wrote: > > Adds the number of performance monitor counters each PowerPC > processor has to > > the cpu table.  Makes oprofile support a bit cleaner since we dont > need a case > > statement on processor version to determine the number of counters. > > > > Signed-off-by: Kumar Gala > > > > -- > > > > diff -Nru a/arch/ppc/kernel/cputable.c b/arch/ppc/kernel/cputable.c > > --- a/arch/ppc/kernel/cputable.c      2004-11-08 21:02:51 -06:00 > > +++ b/arch/ppc/kernel/cputable.c      2004-11-08 21:02:51 -06:00 > > @@ -82,6 +82,7 @@ > >       CPU_FTR_601 | CPU_FTR_HPTE_TABLE, > >       COMMON_PPC | PPC_FEATURE_601_INSTR | PPC_FEATURE_UNIFIED_CACHE, > >       32, 32, > > +     0, > >       __setup_cpu_601 > >      }, > >      {        /* 603 */ > > Perhaps you want to switch to C99-style struct initialization as well? I can change it C99-style as well as fixing the formatting, just wanted to see if there we any other comments. Will resend with those changes if I dont hear any other feedback. - kumar