All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Owens <kaos@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	sekharan@us.ibm.com, ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 0/7]: Fix for unsafe notifier chain
Date: Fri, 09 Dec 2005 15:50:46 +1100	[thread overview]
Message-ID: <7821.1134103846@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Wed, 07 Dec 2005 15:36:12 -0800." <20051207153612.0de2ce38.akpm@osdl.org>

On Wed, 7 Dec 2005 15:36:12 -0800, 
Andrew Morton <akpm@osdl.org> wrote:
>As for the NMIs and RCU: I suspect it was simply a mistake to try to use
>notifier chains for NMI registration in the first place - they are simply
>too complex a data structure for this.  I think I previously suggested
>removing that code and using just a fixed-size array of function pointers.

The notifier chain is a priority ordered list.  Registration and
unregistration must be able to insert and delete anywhere in the list,
which does not fit with a fixed-size array of pointers.

There is also the problem that unregister must not return to its caller
if any NMI type callback is running on any cpu.  The list and function
body are held in caller defined storage and if unregistration returns
too soon then the storage could be freed while the callback is still
executing.

I do not understand why people think that NMI callbacks are a hard
problem to solve.  Besides RCU type solutions, there is also a patch
based on an idea by Corey Minyard, see
http://marc.theaimsgroup.com/?l=linux-kernel&m=113392370322545&w=2.


  parent reply	other threads:[~2005-12-09  4:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-07 20:12 [RFC][PATCH 0/7]: Fix for unsafe notifier chain Alan Stern
2005-12-07 23:36 ` Andrew Morton
2005-12-08 19:53   ` Alan Stern
2005-12-13  5:02     ` Keith Owens
2005-12-13 15:06       ` Alan Stern
2005-12-13 23:36         ` Andrew Morton
2005-12-09  4:50   ` Keith Owens [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-11-19  2:19 Chandra Seetharaman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7821.1134103846@kao2.melbourne.sgi.com \
    --to=kaos@sgi.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sekharan@us.ibm.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.