From: hooanon05@yahoo.co.jp
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, hch@infradead.org, mhalcrow@us.ibm.com,
hugh@veritas.com
Subject: Re: [2.6.26 PATCH, RESEND]: fs_stack/eCryptfs: fsstack_copy_* updates
Date: Mon, 12 May 2008 09:44:28 +0900 [thread overview]
Message-ID: <7830.1210553068@jrobl> (raw)
In-Reply-To: <200805020558.m425w5xN001504@agora.fsl.cs.sunysb.edu>
Erez Zadok:
> The nice thing about these two helpers is fsstack_copy_inode_size becomes a
> lot cleaner and more elegant:
>
> void fsstack_copy_inode_size(struct inode *dst, struct inode *src)
> {
> i_blocks_write(dst, i_blocks_read(src));
> i_size_write(dst, i_size_read(src));
> }
While this function looks simple, I think it is more generic and better
that the caller of fsstack_copy_inode_size() holds i_lock instead of
lock it in the callee.
Junjiro Okajima
next prev parent reply other threads:[~2008-05-12 0:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 6:50 [2.6.26 PATCH, RESEND]: fs_stack/eCryptfs: fsstack_copy_* updates Erez Zadok
2008-04-30 17:17 ` Andrew Morton
2008-04-30 21:09 ` Erez Zadok
2008-04-30 21:25 ` Andrew Morton
2008-05-01 17:18 ` Erez Zadok
2008-05-01 19:21 ` Andrew Morton
2008-05-01 23:44 ` Erez Zadok
2008-05-02 0:08 ` Andrew Morton
2008-05-02 5:58 ` Erez Zadok
2008-05-02 6:11 ` Andrew Morton
2008-05-12 0:44 ` hooanon05 [this message]
2008-05-02 13:17 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7830.1210553068@jrobl \
--to=hooanon05@yahoo.co.jp \
--cc=akpm@linux-foundation.org \
--cc=ezk@cs.sunysb.edu \
--cc=hch@infradead.org \
--cc=hugh@veritas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@us.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.