All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Chunyu Hu <chuhu@redhat.com>,
	akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org,
	ljs@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
	vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com,
	npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
	baohua@kernel.org, lance.yang@linux.dev
Subject: Re: [PATCH v4 3/5] selftests/mm: move write_file helper to vm_util
Date: Thu, 19 Mar 2026 22:48:38 +0100	[thread overview]
Message-ID: <78352e6f-fa40-41ee-b044-62f682f3ca43@kernel.org> (raw)
In-Reply-To: <20260319160656.1480279-4-chuhu@redhat.com>


> +
> +void write_file(const char *path, const char *buf, size_t buflen)
> +{
> +	int fd;
> +	ssize_t numwritten;
> +
> +	fd = open(path, O_WRONLY);
> +	if (fd == -1)
> +		ksft_exit_fail_msg("%s open failed: %s\n", path, strerror(errno));
> +
> +	numwritten = write(fd, buf, buflen - 1);
> +	close(fd);
> +	if (numwritten < 1)
> +		ksft_exit_fail_msg("Write failed\n");
I guess we could indeed test here easily for

	if (numwritten != buflen - 1)

But then, we don't really expect only partial writes to succeed here.

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David

  parent reply	other threads:[~2026-03-19 21:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 16:06 [PATCH v4 0/5] selftests/mm: skip several tests when thp is not available Chunyu Hu
2026-03-19 16:06 ` [PATCH v4 1/5] selftests/mm/guard-regions: skip collapse test when thp not enabled Chunyu Hu
2026-03-19 17:21   ` Mike Rapoport
2026-03-19 19:05   ` Zi Yan
2026-03-19 21:46   ` David Hildenbrand (Arm)
2026-03-19 16:06 ` [PATCH v4 2/5] selftests/mm: soft-dirty: skip two tests when thp is not available Chunyu Hu
2026-03-19 16:06 ` [PATCH v4 3/5] selftests/mm: move write_file helper to vm_util Chunyu Hu
2026-03-19 17:20   ` Mike Rapoport
2026-03-19 19:06   ` Zi Yan
2026-03-19 21:48   ` David Hildenbrand (Arm) [this message]
2026-03-23  3:10     ` Chunyu Hu
2026-03-19 16:06 ` [PATCH v4 4/5] selftests/mm: split_huge_page_test: skip the test when thp is not available Chunyu Hu
2026-03-19 16:06 ` [PATCH v4 5/5] selftests/mm: transhuge_stress: skip the test when thp " Chunyu Hu
2026-03-20  2:46 ` [PATCH v4 0/5] selftests/mm: skip several tests when thp is " Andrew Morton
2026-03-23  3:21   ` Chunyu Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78352e6f-fa40-41ee-b044-62f682f3ca43@kernel.org \
    --to=david@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=chuhu@redhat.com \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=npache@redhat.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.