From: Paul Barker <paul.barker@sancloud.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH v3 1/3] efi_loader: Add SPI I/O protocol support
Date: Mon, 3 Oct 2022 13:05:23 +0100 [thread overview]
Message-ID: <783bca04-443f-e25e-d76b-064665e80b9c@sancloud.com> (raw)
In-Reply-To: <8f5bcacf-65b1-42aa-ff7f-d770b93e3cec@gmx.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 611 bytes --]
Addressing only the comments which I've not covered in my reply to Ilias' email:
On 26/09/2022 14:13, Heinrich Schuchardt wrote:
> On 9/26/22 14:43, Ilias Apalodimas wrote:
>> On Wed, Sep 21, 2022 at 05:06:26PM +0100, Paul Barker wrote:
>>> +static efi_string_t convert_efi_string(const char *str)
>>> +{
>>> + efi_string_t str_16, tmp;
>>> + size_t sz_8, sz_16;
>>> +
>>> + sz_8 = strlen(str);
>
> sz_8 seems to be unused.
I'll drop this in v4.
Thanks,
--
Paul Barker
Principal Software Engineer
SanCloud Ltd
e: paul.barker@sancloud.com
w: https://sancloud.com/
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6865 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-10-03 12:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 16:06 [PATCH v3 0/3] Support UEFI SPI I/O protocol Paul Barker
2022-09-21 16:06 ` [PATCH v3 1/3] efi_loader: Add SPI I/O protocol support Paul Barker
2022-09-26 12:43 ` Ilias Apalodimas
2022-09-26 13:13 ` Heinrich Schuchardt
2022-09-26 13:40 ` Ilias Apalodimas
2022-10-03 12:05 ` Paul Barker [this message]
2022-10-03 12:00 ` Paul Barker
2022-09-26 13:52 ` Heinrich Schuchardt
2022-10-03 12:05 ` Paul Barker
2022-10-04 16:31 ` Paul Barker
2022-10-04 17:25 ` Heinrich Schuchardt
2022-09-21 16:06 ` [PATCH v3 2/3] arm: dts: am335x-sancloud-bbe-lite: UEFI SPI export Paul Barker
2022-09-21 16:15 ` Tom Rini
2022-09-26 11:33 ` Ilias Apalodimas
2022-09-26 13:13 ` Tom Rini
2022-09-26 13:33 ` Heinrich Schuchardt
2022-09-26 19:13 ` Tom Rini
2022-09-21 16:06 ` [PATCH v3 3/3] am335x_evm_defconfig: Enable Micron SPI flash support Paul Barker
2022-09-26 13:21 ` Heinrich Schuchardt
2022-10-03 12:07 ` Paul Barker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=783bca04-443f-e25e-d76b-064665e80b9c@sancloud.com \
--to=paul.barker@sancloud.com \
--cc=ilias.apalodimas@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.