From: Vishnu Dasa <vdasa@vmware.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Jorgen Hansen <jhansen@vmware.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"acking@vmware.com" <acking@vmware.com>,
"dtor@vmware.com" <dtor@vmware.com>,
Pv-drivers <Pv-drivers@vmware.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 1/3] VMCI: Fix the description of vmci_check_host_caps()
Date: Thu, 17 Feb 2022 07:08:57 +0000 [thread overview]
Message-ID: <7844DB64-F8A6-49C2-A0A7-0A9AA634BFDA@vmware.com> (raw)
In-Reply-To: <7f7ad8c171566f6f8716c3451b9ddc2e83fe003f.1644531317.git.christophe.jaillet@wanadoo.fr>
> On Feb 10, 2022, at 2:27 PM, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>
> vmci_check_host_caps() doesn't return a bool but an int.
> Fix the description accordingly.
>
> Fixes: 782f24453536 ("VMCI: fix error handling path when registering guest driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/misc/vmw_vmci/vmci_guest.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmci_guest.c
> index aa61a687b3e2..1a1858742f75 100644
> --- a/drivers/misc/vmw_vmci/vmci_guest.c
> +++ b/drivers/misc/vmw_vmci/vmci_guest.c
> @@ -253,9 +253,9 @@ static void vmci_guest_cid_update(u32 sub_id,
>
> /*
> * Verify that the host supports the hypercalls we need. If it does not,
> - * try to find fallback hypercalls and use those instead. Returns
> - * true if required hypercalls (or fallback hypercalls) are
> - * supported by the host, false otherwise.
> + * try to find fallback hypercalls and use those instead. Returns 0 if
> + * required hypercalls (or fallback hypercalls) are supported by the host,
> + * an error code otherwise.
> */
> static int vmci_check_host_caps(struct pci_dev *pdev)
> {
> --
> 2.32.0
>
Thanks!
Acked-by: Vishnu Dasa <vdasa@vmware.com>
next prev parent reply other threads:[~2022-02-17 7:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 22:26 [PATCH 0/3] VMCI: Various fixes Christophe JAILLET
2022-02-10 22:27 ` [PATCH 1/3] VMCI: Fix the description of vmci_check_host_caps() Christophe JAILLET
2022-02-17 7:08 ` Vishnu Dasa [this message]
2022-02-10 22:27 ` [PATCH 2/3] VMCI: No need to clear memory after a dma_alloc_coherent() call Christophe JAILLET
2022-02-17 7:10 ` Vishnu Dasa
2022-02-10 22:27 ` [PATCH 3/3] VMCI: Fix some error handling paths in vmci_guest_probe_device() Christophe JAILLET
2022-02-11 14:09 ` Dan Carpenter
2022-02-11 20:06 ` Christophe JAILLET
2022-02-24 6:53 ` Vishnu Dasa
2022-02-24 10:03 ` Dan Carpenter
2022-02-24 16:08 ` Vishnu Dasa
2022-02-24 0:43 ` Vishnu Dasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7844DB64-F8A6-49C2-A0A7-0A9AA634BFDA@vmware.com \
--to=vdasa@vmware.com \
--cc=Pv-drivers@vmware.com \
--cc=acking@vmware.com \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dtor@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhansen@vmware.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.