From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB586CD5BB3 for ; Fri, 22 May 2026 07:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8QJShRGeFpw8RC25CYn4eGHqpkrKIps8Iyqz73CEiDQ=; b=B58lhuCTSCVu5T oH3+vyHeDvFKs5jZRnXNsf+1PT0z+wwXjE5fLOEdyGAj2Z4qCxKoV1R2ftCaZQrkOQpA7zba4xLMz aG6468laMqWHpkO7sy7ZJc46dmuWOI0Z9EqTrc4GaE/uh7X2HU3wbq7LLqF654FB3ae/VJG373e+G jwtXnrcT/9Xm/9mAYlR7BS5XTGJI1YYDA6Ze0f1OhkZA1c+v+U3MxpKVs6w3LMQ930V5wEYuwQ46V IqEamopdM1BVPxcVahTPbaLIhpRQZSKbYeEbDegfPpuP8y2otIf9Wpszd11/c+li1ZxIIlzhQ8zLM UmhjbMwdfsjzMwFTxE2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQKBN-0000000A43H-0RGn; Fri, 22 May 2026 07:20:33 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQKBK-0000000A421-1Bci; Fri, 22 May 2026 07:20:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=+2URYXFsdVZ7zfE6UHaRcVDaEOGeqXpHsK6sM6HYXxw=; b=UV9FlgTJ+SpBVSlQknaczKW1He 0KdJMHYQO06VGWA2ke80QVYABG29Wjp2+inK0WpjBCWHQWKWu51yEzHk4cnqUpXgCr9LHdEZzAND4 HixlCGro6pQBcX/IKZOlsY86FmBmLLWnDQglnk06zfl6wi4BrW7sWDPDjAlvcR+HGShk3FTAjdvf9 vp+JBtgg59CjIs9vKc0bqvhv5OJQ0pTzdyXYCMJXVc2fHkDwiIMKhJsUX7xtEFCYYrVBqC/m8tESA EeKM5Q7FICE+UhXPl1y4pKqiMgFTzLI5+fq0WjqLWnDXyc2rxqv5JOueMCiqD1BoUGe949aLeNJQV 4AXKitKQ==; From: Heiko Stuebner To: Heiko Stuebner Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Philipp Zabel , Steven Price , Bartosz Golaszewski Subject: Re: [PATCH] ARM: rockchip: keep reset control around Date: Fri, 22 May 2026 09:20:23 +0200 Message-ID: <7845032.1B3tZ46Xf9@phil> In-Reply-To: <20260521210915.2331176-1-heiko@sntech.de> References: <20260521210915.2331176-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260522_002030_349355_7DA308A6 X-CRM114-Status: GOOD ( 22.00 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org QW0gRG9ubmVyc3RhZywgMjEuIE1haSAyMDI2LCAyMzowOToxNSBNaXR0ZWxldXJvcMOkaXNjaGUg U29tbWVyemVpdCBzY2hyaWViIEhlaWtvIFN0dWVibmVyOgo+IERvIG5vdCBwdXQgdGhlIHJlc2V0 IGNvbnRyb2wsIHJldGFpbiBleGNsdXNpdmUgY29udHJvbCBvdmVyIGl0Lgo+IEFmdGVyIHR1cm5p bmcgb24gYSBDUFUsIHRoZSBjb3JyZXNwb25kaW5nIHJlc2V0IGxpbmUgbXVzdCBzdGF5Cj4gZGVh c3NlcnRlZC4KPiAKPiBUaGlzIGFsc28gYXZvaWRzIGNhbGxpbmcgcmVzZXRfY29udHJvbF9wdXQo KSBiZWZvcmUgd29ya3F1ZXVlcwo+IGFyZSBvcGVyYXRpb25hbC4KPiAKPiBGaXhlczogNzhlYmJm ZjZkMWEwICgicmVzZXQ6IGhhbmRsZSByZW1vdmluZyBzdXBwbGllciBiZWZvcmUgY29uc3VtZXJz IikKPiBTaWduZWQtb2ZmLWJ5OiBQaGlsaXBwIFphYmVsIDxwLnphYmVsQHBlbmd1dHJvbml4LmRl Pgo+IFRlc3RlZC1ieTogU3RldmVuIFByaWNlIDxzdGV2ZW4ucHJpY2VAYXJtLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBIZWlrbyBTdHVlYm5lciA8aGVpa29Ac250ZWNoLmRlPgo+IC0tLQo+ICBhcmNo L2FybS9tYWNoLXJvY2tjaGlwL3BsYXRzbXAuYyB8IDE2ICsrKysrKysrKystLS0tLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2FyY2gvYXJtL21hY2gtcm9ja2NoaXAvcGxhdHNtcC5jIGIvYXJjaC9hcm0vbWFjaC1y b2NrY2hpcC9wbGF0c21wLmMKPiBpbmRleCBmNDMyZDIyYmZlZDguLmY2NTlkODk0YmZhZSAxMDA2 NDQKPiAtLS0gYS9hcmNoL2FybS9tYWNoLXJvY2tjaGlwL3BsYXRzbXAuYwo+ICsrKyBiL2FyY2gv YXJtL21hY2gtcm9ja2NoaXAvcGxhdHNtcC5jCj4gQEAgLTM0LDYgKzM0LDcgQEAgc3RhdGljIGlu dCBuY29yZXM7Cj4gIAo+ICBzdGF0aWMgc3RydWN0IHJlZ21hcCAqcG11Owo+ICBzdGF0aWMgaW50 IGhhc19wbXUgPSB0cnVlOwo+ICtzdGF0aWMgc3RydWN0IHJlc2V0X2NvbnRyb2wgKmNwdV9yc3Rj WzRdOwoKQWZ0ZXIgc2xlZXBpbmcgb24gdGhhdCwgdGhpcyBzaG91bGQgYmUgY3B1X3JzdGNbNV07 CgpDb3JldHgtQTkgU29DcyBuZWVkIHRvIGVuYWJsZSB0aGUgU0NVIHBvd2VyLWRvbWFpbiB3aGlj aCB0aGFua2Z1bGx5CnNpdHMgYXQgaW5kZXggNCBvZiB0aGUgcG93ZXItZG9tYWluIHJlZ2lzdGVy LgoKU28gd2hpbGUgd2UgKGFscmVhZHkpIGV4cGVjdCBubyByZXNldCBjb250cm9sIGZvciB0aGF0 LCB3ZSBuZWVkIGF0IGxlYXN0Cm1ha2Ugc3VyZSwgaXQncyBub3QgcmVhZGluZyBpbnRvIHVuZGVm aW5lZCBtZW1vcnkgYW5kIHRodXMgbmVlZCB0aGF0CmVtcHR5IGZpZWxkIGluIHRoZSBhcnJheS4K CgpIZWlrbwoKPiAgCj4gIHN0YXRpYyBpbnQgcG11X3Bvd2VyX2RvbWFpbl9pc19vbihpbnQgcGQp Cj4gIHsKPiBAQCAtNjQsOSArNjUsMTEgQEAgc3RhdGljIHN0cnVjdCByZXNldF9jb250cm9sICpy b2NrY2hpcF9nZXRfY29yZV9yZXNldChpbnQgY3B1KQo+ICBzdGF0aWMgaW50IHBtdV9zZXRfcG93 ZXJfZG9tYWluKGludCBwZCwgYm9vbCBvbikKPiAgewo+ICAJdTMyIHZhbCA9IChvbikgPyAwIDog QklUKHBkKTsKPiAtCXN0cnVjdCByZXNldF9jb250cm9sICpyc3RjID0gcm9ja2NoaXBfZ2V0X2Nv cmVfcmVzZXQocGQpOwo+ICsJc3RydWN0IHJlc2V0X2NvbnRyb2wgKnJzdGM7Cj4gIAlpbnQgcmV0 Owo+ICAKPiArCXJzdGMgPSBwZCA8IEFSUkFZX1NJWkUoY3B1X3JzdGMpID8gY3B1X3JzdGNbcGRd IDogRVJSX1BUUigtRUlOVkFMKTsKPiArCj4gIAlpZiAoSVNfRVJSKHJzdGMpICYmIHJlYWRfY3B1 aWRfcGFydCgpICE9IEFSTV9DUFVfUEFSVF9DT1JURVhfQTkpIHsKPiAgCQlwcl9lcnIoIiVzOiBj b3VsZCBub3QgZ2V0IHJlc2V0IGNvbnRyb2wgZm9yIGNvcmUgJWRcbiIsCj4gIAkJICAgICAgIF9f ZnVuY19fLCBwZCk7Cj4gQEAgLTEwMCwxMSArMTAzLDggQEAgc3RhdGljIGludCBwbXVfc2V0X3Bv d2VyX2RvbWFpbihpbnQgcGQsIGJvb2wgb24pCj4gIAkJfQo+ICAJfQo+ICAKPiAtCWlmICghSVNf RVJSKHJzdGMpKSB7Cj4gLQkJaWYgKG9uKQo+IC0JCQlyZXNldF9jb250cm9sX2RlYXNzZXJ0KHJz dGMpOwo+IC0JCXJlc2V0X2NvbnRyb2xfcHV0KHJzdGMpOwo+IC0JfQo+ICsJaWYgKCFJU19FUlIo cnN0YykgJiYgb24pCj4gKwkJcmVzZXRfY29udHJvbF9kZWFzc2VydChyc3RjKTsKPiAgCj4gIAly ZXR1cm4gMDsKPiAgfQo+IEBAIC0zMTIsNiArMzEyLDEwIEBAIHN0YXRpYyB2b2lkIF9faW5pdCBy b2NrY2hpcF9zbXBfcHJlcGFyZV9jcHVzKHVuc2lnbmVkIGludCBtYXhfY3B1cykKPiAgCQluY29y ZXMgPSAoKGwyY3RsciA+PiAyNCkgJiAweDMpICsgMTsKPiAgCX0KPiAgCj4gKwkvKiBDb2xsZWN0 IGNwdSBjb3JlIHJlc2V0IGNvbnRyb2wgZm9yIGVhY2ggY29yZSAqLwo+ICsJZm9yIChpID0gMDsg aSA8IG5jb3JlczsgaSsrKQo+ICsJCWNwdV9yc3RjW2ldID0gcm9ja2NoaXBfZ2V0X2NvcmVfcmVz ZXQoaSk7Cj4gKwo+ICAJLyogTWFrZSBzdXJlIHRoYXQgYWxsIGNvcmVzIGV4Y2VwdCB0aGUgZmly c3QgYXJlIHJlYWxseSBvZmYgKi8KPiAgCWZvciAoaSA9IDE7IGkgPCBuY29yZXM7IGkrKykKPiAg CQlwbXVfc2V0X3Bvd2VyX2RvbWFpbigwICsgaSwgZmFsc2UpOwo+IAoKCgoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxp bmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36B00CD5BB3 for ; Fri, 22 May 2026 07:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+2URYXFsdVZ7zfE6UHaRcVDaEOGeqXpHsK6sM6HYXxw=; b=NT64KAdRR1dllylqxWLVcsnHzQ W46wta4CBoGEv7KNcpaXnJSd2JHzp9hAn6eqknpvZz/mhKYQBXNBcXAO5J8pMSqircz1LISMftjC0 NQOJdoiAMFJpNeHLpoHpB34ZRdvMtUOffrcpKEe5F0EuGi2SAK8HV6iiOI0auT9vs+Txs0GXsfGTw b/kEJGMWsvQ1cnKBqFitvK539mfn0Rfy2DnK1FEa8lfgY+dnWjLU7rBNPb3NKzXBij4Y4kH9dyZLj 6SrqEZWSQ5K5lxK3tJVGn6g0lmqWXMuCyBAOBySk0O/JTqKP0I6xEnY8i2vBtjesC0LccvdZJ9wl9 hIDnXELQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQKBN-0000000A431-05C5; Fri, 22 May 2026 07:20:33 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQKBK-0000000A421-1Bci; Fri, 22 May 2026 07:20:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=+2URYXFsdVZ7zfE6UHaRcVDaEOGeqXpHsK6sM6HYXxw=; b=UV9FlgTJ+SpBVSlQknaczKW1He 0KdJMHYQO06VGWA2ke80QVYABG29Wjp2+inK0WpjBCWHQWKWu51yEzHk4cnqUpXgCr9LHdEZzAND4 HixlCGro6pQBcX/IKZOlsY86FmBmLLWnDQglnk06zfl6wi4BrW7sWDPDjAlvcR+HGShk3FTAjdvf9 vp+JBtgg59CjIs9vKc0bqvhv5OJQ0pTzdyXYCMJXVc2fHkDwiIMKhJsUX7xtEFCYYrVBqC/m8tESA EeKM5Q7FICE+UhXPl1y4pKqiMgFTzLI5+fq0WjqLWnDXyc2rxqv5JOueMCiqD1BoUGe949aLeNJQV 4AXKitKQ==; From: Heiko Stuebner To: Heiko Stuebner Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Philipp Zabel , Steven Price , Bartosz Golaszewski Subject: Re: [PATCH] ARM: rockchip: keep reset control around Date: Fri, 22 May 2026 09:20:23 +0200 Message-ID: <7845032.1B3tZ46Xf9@phil> In-Reply-To: <20260521210915.2331176-1-heiko@sntech.de> References: <20260521210915.2331176-1-heiko@sntech.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260522_002030_349355_7DA308A6 X-CRM114-Status: GOOD ( 22.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Donnerstag, 21. Mai 2026, 23:09:15 Mitteleurop=C3=A4ische Sommerzeit sch= rieb Heiko Stuebner: > Do not put the reset control, retain exclusive control over it. > After turning on a CPU, the corresponding reset line must stay > deasserted. >=20 > This also avoids calling reset_control_put() before workqueues > are operational. >=20 > Fixes: 78ebbff6d1a0 ("reset: handle removing supplier before consumers") > Signed-off-by: Philipp Zabel > Tested-by: Steven Price > Signed-off-by: Heiko Stuebner > --- > arch/arm/mach-rockchip/platsmp.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) >=20 > diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/pl= atsmp.c > index f432d22bfed8..f659d894bfae 100644 > --- a/arch/arm/mach-rockchip/platsmp.c > +++ b/arch/arm/mach-rockchip/platsmp.c > @@ -34,6 +34,7 @@ static int ncores; > =20 > static struct regmap *pmu; > static int has_pmu =3D true; > +static struct reset_control *cpu_rstc[4]; After sleeping on that, this should be cpu_rstc[5]; Coretx-A9 SoCs need to enable the SCU power-domain which thankfully sits at index 4 of the power-domain register. So while we (already) expect no reset control for that, we need at least make sure, it's not reading into undefined memory and thus need that empty field in the array. Heiko > =20 > static int pmu_power_domain_is_on(int pd) > { > @@ -64,9 +65,11 @@ static struct reset_control *rockchip_get_core_reset(i= nt cpu) > static int pmu_set_power_domain(int pd, bool on) > { > u32 val =3D (on) ? 0 : BIT(pd); > - struct reset_control *rstc =3D rockchip_get_core_reset(pd); > + struct reset_control *rstc; > int ret; > =20 > + rstc =3D pd < ARRAY_SIZE(cpu_rstc) ? cpu_rstc[pd] : ERR_PTR(-EINVAL); > + > if (IS_ERR(rstc) && read_cpuid_part() !=3D ARM_CPU_PART_CORTEX_A9) { > pr_err("%s: could not get reset control for core %d\n", > __func__, pd); > @@ -100,11 +103,8 @@ static int pmu_set_power_domain(int pd, bool on) > } > } > =20 > - if (!IS_ERR(rstc)) { > - if (on) > - reset_control_deassert(rstc); > - reset_control_put(rstc); > - } > + if (!IS_ERR(rstc) && on) > + reset_control_deassert(rstc); > =20 > return 0; > } > @@ -312,6 +312,10 @@ static void __init rockchip_smp_prepare_cpus(unsigne= d int max_cpus) > ncores =3D ((l2ctlr >> 24) & 0x3) + 1; > } > =20 > + /* Collect cpu core reset control for each core */ > + for (i =3D 0; i < ncores; i++) > + cpu_rstc[i] =3D rockchip_get_core_reset(i); > + > /* Make sure that all cores except the first are really off */ > for (i =3D 1; i < ncores; i++) > pmu_set_power_domain(0 + i, false); >=20