From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Nikhil Devshatwar <nikhil.nd@ti.com>, <dri-devel@lists.freedesktop.org>
Cc: Sekhar Nori <nsekhar@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Yuti Amonkar <yamonkar@cadence.com>,
Swapnil Jakhade <sjakhade@cadence.com>
Subject: Re: [PATCH v3 6/6] drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable
Date: Mon, 23 Nov 2020 16:54:30 +0200 [thread overview]
Message-ID: <784bb22e-2199-cdfd-985b-5c58474e1e88@ti.com> (raw)
In-Reply-To: <20201119160134.9244-7-nikhil.nd@ti.com>
On 19/11/2020 18:01, Nikhil Devshatwar wrote:
> When removing the tidss driver, there is a warning reported by
> kernel about an unhandled interrupt for mhdp driver.
>
> [ 43.238895] irq 31: nobody cared (try booting with the "irqpoll" option)
> ... [snipped backtrace]
> [ 43.330735] handlers:
> [ 43.333020] [<000000005367c4f9>] irq_default_primary_handler threaded [<000000007e02b601>]
> cdns_mhdp_irq_handler [cdns_mhdp8546]
> [ 43.344607] Disabling IRQ #31
>
> This happens because as part of cdns_mhdp_bridge_hpd_disable, driver tries
> to disable the interrupts. While disabling the SW_EVENT interrupts,
> it accidentally enables the MBOX interrupts, which are not handled by
> the driver.
>
> Fix this with a read-modify-write to update only required bits.
> Use the enable / disable function as required in other places.
>
> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> Reviewed-by: Swapnil Jakhade <sjakhade@cadence.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
I think this is fine as a fix for this issue, but at some point the irq management needs some work.
E.g. we call cdns_mhdp_bridge_hpd_enable when attaching/enabling the hw, but also via
drm_bridge_funcs->hpd_enable. This doesn't make sense, as one of those calls doesn't achieve
anything, as cdns_mhdp_bridge_hpd_enable has already been called.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-11-23 14:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 16:01 [PATCH v3 0/6] drm/tidss: Use new connector model for tidss Nikhil Devshatwar
2020-11-19 16:01 ` [PATCH v3 1/6] drm: bridge: Propagate the bus flags from bridge->timings Nikhil Devshatwar
2020-11-30 9:36 ` Laurent Pinchart
2020-11-30 9:46 ` Tomi Valkeinen
2020-11-30 9:47 ` Laurent Pinchart
2020-11-30 10:02 ` Tomi Valkeinen
2020-11-30 10:04 ` Tomi Valkeinen
2020-11-30 18:59 ` Laurent Pinchart
2020-12-01 10:52 ` Nikhil Devshatwar
2020-11-19 16:01 ` [PATCH v3 2/6] drm/bridge: tfp410: Support format negotiation hooks Nikhil Devshatwar
2020-11-30 9:40 ` Laurent Pinchart
2020-11-19 16:01 ` [PATCH v3 3/6] drm/bridge: mhdp8546: Add minimal format negotiation Nikhil Devshatwar
2020-11-19 16:01 ` [PATCH v3 4/6] drm/tidss: Set bus_format correctly from bridge/connector Nikhil Devshatwar
2020-11-25 12:51 ` Tomi Valkeinen
2020-11-30 6:35 ` Nikhil Devshatwar
2020-11-30 9:46 ` Laurent Pinchart
2020-12-01 10:57 ` Nikhil Devshatwar
2020-12-01 15:53 ` Tomi Valkeinen
2020-11-30 9:45 ` Laurent Pinchart
2020-12-01 10:52 ` Nikhil Devshatwar
2020-11-19 16:01 ` [PATCH v3 5/6] drm/tidss: Move to newer connector model Nikhil Devshatwar
2020-11-19 16:01 ` [PATCH v3 6/6] drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable Nikhil Devshatwar
2020-11-23 14:54 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=784bb22e-2199-cdfd-985b-5c58474e1e88@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=nikhil.nd@ti.com \
--cc=nsekhar@ti.com \
--cc=sjakhade@cadence.com \
--cc=yamonkar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.