Re: [meta-oe][PATCH] abseil-cpp: add recipe for git version

[Sinan Kaya <okaya@kernel.org>]

On 2/9/2020 2:53 AM, Khem Raj wrote:
>> +SUMMARY = "Abseil is a cpp library like STL"
>> +DESCRIPTION = "It's got containers, algorithms, useful stuff!"
> maybe we can be more specific about it from
> https://github.com/abseil/abseil-cpp/blob/master/README.md
> 
>> +HOMEPAGE = ""
> perhaps https://abseil.io/ instead of leaving it empty is better.
> 
done

>> +SECTION = "libs"
>> +LICENSE = "Apache-2"
> The current value is not wrong but Apache-2.0 would be better to match SPDX
> 
done

>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=df52c6edb7adc22e533b2bacc3bd3915"
>> +
>> +SRCREV = "aa844899c937bde5d2b24f276b59997e5b668bde"
>> +BRANCH = "lts_2019_08_08"
>> +SRC_URI = "git://github.com/abseil/abseil-cpp;branch=${BRANCH}         \
>> +           file://0001-Remove-maes-option-from-cross-compilation.patch \
>> +          "
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +TARGET_CXXFLAGS += "${@bb.utils.contains('TARGET_ARCH', 'aarch64', '
>> -march=armv8-a+crypto', '', d)}"
>> +TARGET_CXXFLAGS += "${@bb.utils.contains('TARGET_ARCH', 'x64', ' -maes -msse4.1', '', d)}"
>> +
>> +CXXFLAGS_append_class-nativesdk = " -Wl,--no-as-needed -fPIC"
>> +CXXFLAGS_append_class-native = " -Wl,--no-as-needed -fPIC"
> perhaps use ASNEEDED_<override> = ""

done

> 
>> +CXXFLAGS_append_class-target = " -fPIC"
>> +
>> +inherit cmake
>> +
>> +BBCLASSEXTEND = "native nativesdk"
>> +ALLOW_EMPTY_${PN} = "1"
> why do we need this ?

Library generates an empty $PN package and I had problems linking the
library to the new grpc version without producing the empty ${PN}.
This library is requires by the newer grpc versions.