All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: "Orzel, Michal" <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2 1/8] xen/arm: drop declaration of handle_device_interrupts()
Date: Tue, 22 Apr 2025 16:31:14 +0200	[thread overview]
Message-ID: <7856ff9f-3cd8-4591-930e-9c9d43cedcd7@gmail.com> (raw)
In-Reply-To: <b6bb9905-befd-4ebd-a50d-a5a1c82f53bc@amd.com>

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]


On 4/17/25 9:38 AM, Orzel, Michal wrote:
>
> On 14/04/2025 17:56, Oleksii Kurochko wrote:
>> There is no any users of handle_device_interrupts() thereby it
>> could be dropped.
> It reads as if you were dropping a definition. There is no definition, therefore
> no users. Prototype was added by accident in:
> 8d2c3ab18cc1fce46945bd3aa1819a7aea0c564e

I will reword it to:
  There is no definition of handle_device_interrupts() thereby it could be dropped.

Should I add Fixes tag to mention that it was added by accident in
8d2c3ab18cc1fce46945bd3aa1819a7aea0c564e? Or it will be enough just to mention that
in the commit message?

>
>> Signed-off-by: Oleksii Kurochko<oleksii.kurochko@gmail.com>
> With the commit msg updated to be more meaningful:
> Reviewed-by: Michal Orzel<michal.orzel@amd.com>

Thanks.

~ Oleksii

[-- Attachment #2: Type: text/html, Size: 1821 bytes --]

  reply	other threads:[~2025-04-22 14:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 15:56 [PATCH v2 0/8] Move parts of Arm's Dom0less to common code Oleksii Kurochko
2025-04-14 15:56 ` [PATCH v2 1/8] xen/arm: drop declaration of handle_device_interrupts() Oleksii Kurochko
2025-04-17  7:38   ` Orzel, Michal
2025-04-22 14:31     ` Oleksii Kurochko [this message]
2025-04-22 14:32       ` Orzel, Michal
2025-04-14 15:56 ` [PATCH v2 2/8] xen/common: dom0less: make some parts of Arm's CONFIG_DOM0LESS common Oleksii Kurochko
2025-04-17  8:08   ` Orzel, Michal
2025-04-17  8:11     ` Jan Beulich
2025-04-22 15:08     ` Oleksii Kurochko
2025-04-14 15:56 ` [PATCH v2 3/8] asm-generic: move parts of Arm's asm/kernel.h to common code Oleksii Kurochko
2025-04-14 15:56 ` [PATCH v2 4/8] arm/static-shmem.h: drop inclusion of asm/setup.h Oleksii Kurochko
2025-04-14 15:56 ` [PATCH v2 5/8] asm-generic: move some parts of Arm's domain_build.h to common Oleksii Kurochko
2025-04-17 14:36   ` Jan Beulich
2025-04-22 15:12     ` Oleksii Kurochko
2025-04-22 15:43       ` Jan Beulich
2025-04-14 15:56 ` [PATCH v2 6/8] xen/common: dom0less: introduce common kernel.c Oleksii Kurochko
2025-04-14 15:56 ` [PATCH v2 7/8] xen/common: dom0less: introduce common domain-build.c Oleksii Kurochko
2025-04-17 14:45   ` Jan Beulich
2025-04-22 15:26     ` Oleksii Kurochko
2025-04-22 15:36       ` Oleksii Kurochko
2025-04-22 15:53       ` Jan Beulich
2025-04-14 15:56 ` [PATCH v2 8/8] xen/common: dom0less: introduce common dom0less-build.c Oleksii Kurochko
2025-05-01  0:55 ` [PATCH v2 0/8] Move parts of Arm's Dom0less to common code Stefano Stabellini
2025-05-01 14:23   ` Oleksii Kurochko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7856ff9f-3cd8-4591-930e-9c9d43cedcd7@gmail.com \
    --to=oleksii.kurochko@gmail.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=bertrand.marquis@arm.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.