Re: [PATCH mptcp-next] Squash to "selftests: mptcp: print test results with colors"

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 07/03/2024 06:58, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> _printf is dropped now, use mptcp_lib_pr_fail instead.

Good catch.

> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> ---
>  tools/testing/selftests/net/mptcp/userspace_pm.sh | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/mptcp/userspace_pm.sh b/tools/testing/selftests/net/mptcp/userspace_pm.sh
> index 9fc9e574bc27..30652a1c548b 100755
> --- a/tools/testing/selftests/net/mptcp/userspace_pm.sh
> +++ b/tools/testing/selftests/net/mptcp/userspace_pm.sh
> @@ -242,8 +242,7 @@ check_expected_one()
>  		test_fail
>  	fi
>  
> -	_printf "\tExpected value for '%s': '%s', got '%s'.\n" \
> -		"${var}" "${!exp}" "${!var}"
> +	mptcp_lib_pr_fail "Expected value for '${var}': '${!exp}', got '${!var}'."

Maybe best to use 'mptcp_lib_print_err()' instead?
Because a "[FAIL]" will already be printed via test_fail() called just
above.

I will apply this patch with mptcp_lib_print_err instead. Please tell me
if it's not OK.

>  	return 1
>  }
>  

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.