From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Jonah Petri <jonah@petri.us>
Cc: Romain Naour <romain.naour@gmail.com>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] toolchain: handle toolchains with multiple ld*.so.* files
Date: Wed, 25 Aug 2021 01:59:41 +0200 [thread overview]
Message-ID: <786439DF-BDB6-48DC-A913-66DAFC24CD3F@benettiengineering.com> (raw)
In-Reply-To: <98467939-bbe9-17c7-eba2-531e039be28f@petri.us>
Hi Jonah,
> Il giorno 25 ago 2021, alle ore 00:38, Jonah Petri <jonah@petri.us> ha scritto:
>
>
>> On 8/24/21 5:02 PM, Thomas Petazzoni wrote:
>> Hello,
>>
>> On Tue, 24 Aug 2021 16:35:36 -0400
>> Jonah Petri <jonah@petri.us> wrote:
>>
>>> Sorry for the missing SOB - I will resubmit. The instructions on
>>> https://buildroot.org/downloads/manual/manual.html#submitting-patches
>>> might need a modification, as I followed them precisely, I think! Expect
>>> a v2 shortly with a SOB.
>> Thanks for your patch and going through our manual. If you think
>> anything is missing, the manual source code is in docs/manual/, so you
>> can easily send a patch.
>>
>> However, I think this requirement for a Signed-off-by is clearly in our
>> instructions. Section 22.5.1 of our manual has:
>
> Hi Thomas,
>
> Yes, you're right, the requirement is totally clear. I have some error in my understanding of `git send-email`. I'll submit a clarification to the manual once I narrow down exactly what went wrong.
I think that ./utils/get-developers in buildroot folder can help you.
Try to create the patch with:
git format-patch -s -M -o . -1
and then:
./utils/get-developers 0001-your-patch.patch
That will give you the git send-mail command entirely to send your patch. And then you append your patch name to the command.
Best regards
Giulio Benetti
>
> Thanks for all your work,
>
> Jonah
>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-25 0:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 20:16 [Buildroot] [PATCH] toolchain: handle toolchains with multiple ld*.so.* files Jonah Petri
2021-08-24 20:35 ` Jonah Petri
2021-08-24 21:02 ` Thomas Petazzoni
2021-08-24 22:38 ` Jonah Petri
2021-08-24 23:59 ` Giulio Benetti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=786439DF-BDB6-48DC-A913-66DAFC24CD3F@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=buildroot@buildroot.org \
--cc=jonah@petri.us \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.