From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-serial <linux-serial@vger.kernel.org>
Subject: Re: [PATCH] serial: 8250_dw: Emit an error message if getting the baudclk failed
Date: Thu, 22 Feb 2024 13:50:40 +0200 (EET) [thread overview]
Message-ID: <786cecc3-4723-4b96-679e-1ea9736d3f6b@linux.intel.com> (raw)
In-Reply-To: <20240222111922.2016122-2-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On Thu, 22 Feb 2024, Uwe Kleine-König wrote:
> Instead of silently giving up, at least tell what the problem is.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/tty/serial/8250/8250_dw.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index 2d1f350a4bea..94aa3dddb71e 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -597,7 +597,8 @@ static int dw8250_probe(struct platform_device *pdev)
> if (data->clk == NULL)
> data->clk = devm_clk_get_optional_enabled(dev, NULL);
> if (IS_ERR(data->clk))
> - return PTR_ERR(data->clk);
> + return dev_err_probe(dev, PTR_ERR(data->clk),
> + "failed to get baudclk\n");
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2024-02-22 11:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 11:19 [PATCH] serial: 8250_dw: Emit an error message if getting the baudclk failed Uwe Kleine-König
2024-02-22 11:50 ` Ilpo Järvinen [this message]
2024-02-22 13:36 ` Uwe Kleine-König
2024-02-22 13:48 ` Ilpo Järvinen
2024-02-22 14:24 ` Uwe Kleine-König
2024-02-22 15:10 ` Andy Shevchenko
2024-02-22 15:11 ` Andy Shevchenko
2024-02-22 18:37 ` Uwe Kleine-König
2024-02-26 16:00 ` VAMSHI GAJJELA
2024-02-26 16:37 ` Andy Shevchenko
2024-02-28 17:45 ` VAMSHI GAJJELA
2024-02-28 17:59 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=786cecc3-4723-4b96-679e-1ea9736d3f6b@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-serial@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.