From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/6] drm/i915: Remove redundant trailing request flush Date: Mon, 31 Dec 2018 10:25:41 +0000 Message-ID: <78704cc1-e6f0-1956-2522-d7bc3d19dd3a@linux.intel.com> References: <20181228171641.16531-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 49CB189B29 for ; Mon, 31 Dec 2018 10:25:44 +0000 (UTC) In-Reply-To: <20181228171641.16531-1-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI4LzEyLzIwMTggMTc6MTYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBOb3cgdGhhdCB3ZSBw ZXJmb3JtIHRoZSByZXF1ZXN0IGZsdXNoaW5nIGlubGluZSB3aXRoIGVtaXR0aW5nIHRoZQo+IGJy ZWFkY3J1bWIsIHdlIGNhbiByZW1vdmUgdGhlIG5vdyByZWR1bmRhbnQgbWFudWFsIGZsdXNoLiBB bmQgd2UgY2FuCj4gYWxzbyByZW1vdmUgdGhlIGluZnJhc3RydWN0dXJlIHRoYXQgcmVtYWluZWQg b25seSBmb3IgaXRzIHB1cnBvc2UuCj4gCj4gdjI6IGVtaXRfYnJlYWRjcnVtYl9zeiBpcyBpbiBk d29yZHMsIGJ1dCBycS0+cmVzZXJ2ZWRfc3BhY2UgaXMgaW4gYnl0ZXMKPiAKPiBTaWduZWQtb2Zm LWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jICAgICAgICAgIHwgMTQgKysrKysrKy0t LS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyAgICAgIHwg MTYgLS0tLS0tLS0tLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1 ZmZlci5oICAgICAgfCAxMCAtLS0tLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxm dGVzdHMvbW9ja19lbmdpbmUuYyB8ICAyIC0tCj4gICA0IGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0 aW9ucygrKSwgMzUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfcmVxdWVzdC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0 LmMKPiBpbmRleCA2Y2VkY2ZlYTMzYjUuLmVhNDYyMGYyYWM5ZSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfcmVxdWVzdC5jCj4gQEAgLTUyMSwxMCArNTIxLDYgQEAgaTkxNV9yZXF1ZXN0X2Fs bG9jKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgc3RydWN0IGk5MTVfZ2VtX2NvbnRl eHQgKmN0eCkKPiAgIAo+ICAgCXJlc2VydmVfZ3QoaTkxNSk7Cj4gICAKPiAtCXJldCA9IGludGVs X3Jpbmdfd2FpdF9mb3Jfc3BhY2UoY2UtPnJpbmcsIE1JTl9TUEFDRV9GT1JfQUREX1JFUVVFU1Qp Owo+IC0JaWYgKHJldCkKPiAtCQlnb3RvIGVycl91bnJlc2VydmU7Cj4gLQo+ICAgCS8qIE1vdmUg b3VyIG9sZGVzdCByZXF1ZXN0IHRvIHRoZSBzbGFiLWNhY2hlIChpZiBub3QgaW4gdXNlISkgKi8K PiAgIAlycSA9IGxpc3RfZmlyc3RfZW50cnkoJmNlLT5yaW5nLT5yZXF1ZXN0X2xpc3QsIHR5cGVv ZigqcnEpLCByaW5nX2xpbmspOwo+ICAgCWlmICghbGlzdF9pc19sYXN0KCZycS0+cmluZ19saW5r LCAmY2UtPnJpbmctPnJlcXVlc3RfbGlzdCkgJiYKPiBAQCAtNjE2LDkgKzYxMiwxMyBAQCBpOTE1 X3JlcXVlc3RfYWxsb2Moc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLCBzdHJ1Y3QgaTkx NV9nZW1fY29udGV4dCAqY3R4KQo+ICAgCSAqIGk5MTVfcmVxdWVzdF9hZGQoKSBjYWxsIGNhbid0 IGZhaWwuIE5vdGUgdGhhdCB0aGUgcmVzZXJ2ZSBtYXkgbmVlZAo+ICAgCSAqIHRvIGJlIHJlZG9u ZSBpZiB0aGUgcmVxdWVzdCBpcyBub3QgYWN0dWFsbHkgc3VibWl0dGVkIHN0cmFpZ2h0Cj4gICAJ ICogYXdheSwgZS5nLiBiZWNhdXNlIGEgR1BVIHNjaGVkdWxlciBoYXMgZGVmZXJyZWQgaXQuCj4g KwkgKgo+ICsJICogTm90ZSB0aGF0IGR1ZSB0byBob3cgd2UgYWRkIHJlc2VydmVkX3NwYWNlIHRv IGludGVsX3JpbmdfYmVnaW4oKQo+ICsJICogd2UgbmVlZCB0byBkb3VibGUgb3VyIHJlcXVlc3Qg dG8gZW5zdXJlIHRoYXQgaWYgd2UgbmVlZCB0byB3cmFwCj4gKwkgKiBhcm91bmQgaW5zaWRlIGk5 MTVfcmVxdWVzdF9hZGQoKSB0aGVyZSBpcyBzdWZmaWNpZW50IHNwYWNlIGF0Cj4gKwkgKiB0aGUg YmVnaW5uaW5nIG9mIHRoZSByaW5nIGFzIHdlbGwuCgpJcyB0aGVyZSBhIGJlbmVmaXQgb2Yga2Vl cGluZyB0aGlzIGludGVsX3JpbmdfYmVnaW4gYmVoYXZpb3VyPyBJIG1lYW4sIApjb3VsZCB3ZSBq dXN0IGRyb3AgdGhlIHNwZWNpYWwgY2FzaW5nIGluIHRoZXJlIGFuZCBhbHdheXMgd3JhcCB0aGUg d2hvbGUgCnNwYWNlIGZyb20gdGhlIGJlZ2lubmluZyBpZiBlaXRoZXIgcGFydCBkb2VzIG5vdCBm aXQ/IFRoYXQgd291bGQgYWxsb3cgCnRoaXMgcGFydCB0byBwYXNzIGluIHRoZSB0cnVlIHJlc2Vy dmVkIHNwYWNlIHNpemUgSSB0aGluay4KClJlZ2FyZHMsCgpUdnJ0a28KCj4gICAJICovCj4gLQly cS0+cmVzZXJ2ZWRfc3BhY2UgPSBNSU5fU1BBQ0VfRk9SX0FERF9SRVFVRVNUOwo+IC0JR0VNX0JV R19PTihycS0+cmVzZXJ2ZWRfc3BhY2UgPCBlbmdpbmUtPmVtaXRfYnJlYWRjcnVtYl9zeik7Cj4g KwlycS0+cmVzZXJ2ZWRfc3BhY2UgPSAyICogZW5naW5lLT5lbWl0X2JyZWFkY3J1bWJfc3ogKiBz aXplb2YodTMyKTsKPiAgIAo+ICAgCS8qCj4gICAJICogUmVjb3JkIHRoZSBwb3NpdGlvbiBvZiB0 aGUgc3RhcnQgb2YgdGhlIHJlcXVlc3Qgc28gdGhhdAo+IEBAIC04NjAsOCArODYwLDggQEAgdm9p ZCBpOTE1X3JlcXVlc3RfYWRkKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJlcXVlc3QpCj4gICAJICog c2hvdWxkIGFscmVhZHkgaGF2ZSBiZWVuIHJlc2VydmVkIGluIHRoZSByaW5nIGJ1ZmZlci4gTGV0 IHRoZSByaW5nCj4gICAJICoga25vdyB0aGF0IGl0IGlzIHRpbWUgdG8gdXNlIHRoYXQgc3BhY2Ug dXAuCj4gICAJICovCj4gKwlHRU1fQlVHX09OKHJlcXVlc3QtPnJlc2VydmVkX3NwYWNlID4gcmVx dWVzdC0+cmluZy0+c3BhY2UpOwo+ICAgCXJlcXVlc3QtPnJlc2VydmVkX3NwYWNlID0gMDsKPiAt CWVuZ2luZS0+ZW1pdF9mbHVzaChyZXF1ZXN0LCBFTUlUX0ZMVVNIKTsKPiAgIAo+ICAgCS8qCj4g ICAJICogUmVjb3JkIHRoZSBwb3NpdGlvbiBvZiB0aGUgc3RhcnQgb2YgdGhlIGJyZWFkY3J1bWIg c28gdGhhdAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVm ZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBpbmRleCBm YzFlMjkzMDU5NTEuLmQ3NzNmN2RkMzJhOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9yaW5nYnVmZmVyLmMKPiBAQCAtMTkwNCwyMiArMTkwNCw2IEBAIHN0YXRpYyBub2lubGluZSBp bnQgd2FpdF9mb3Jfc3BhY2Uoc3RydWN0IGludGVsX3JpbmcgKnJpbmcsIHVuc2lnbmVkIGludCBi eXRlcykKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPiAgIAo+IC1pbnQgaW50ZWxfcmluZ193YWl0X2Zv cl9zcGFjZShzdHJ1Y3QgaW50ZWxfcmluZyAqcmluZywgdW5zaWduZWQgaW50IGJ5dGVzKQo+IC17 Cj4gLQlHRU1fQlVHX09OKGJ5dGVzID4gcmluZy0+ZWZmZWN0aXZlX3NpemUpOwo+IC0JaWYgKHVu bGlrZWx5KGJ5dGVzID4gcmluZy0+ZWZmZWN0aXZlX3NpemUgLSByaW5nLT5lbWl0KSkKPiAtCQli eXRlcyArPSByaW5nLT5zaXplIC0gcmluZy0+ZW1pdDsKPiAtCj4gLQlpZiAodW5saWtlbHkoYnl0 ZXMgPiByaW5nLT5zcGFjZSkpIHsKPiAtCQlpbnQgcmV0ID0gd2FpdF9mb3Jfc3BhY2UocmluZywg Ynl0ZXMpOwo+IC0JCWlmICh1bmxpa2VseShyZXQpKQo+IC0JCQlyZXR1cm4gcmV0Owo+IC0JfQo+ IC0KPiAtCUdFTV9CVUdfT04ocmluZy0+c3BhY2UgPCBieXRlcyk7Cj4gLQlyZXR1cm4gMDsKPiAt fQo+IC0KPiAgIHUzMiAqaW50ZWxfcmluZ19iZWdpbihzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSwg dW5zaWduZWQgaW50IG51bV9kd29yZHMpCj4gICB7Cj4gICAJc3RydWN0IGludGVsX3JpbmcgKnJp bmcgPSBycS0+cmluZzsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cmluZ2J1ZmZlci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4g aW5kZXggMzI2MDZkNzk1YWYzLi45OWUyY2I3NWQyOWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gQEAgLTc1NCw3ICs3NTQsNiBAQCB2b2lkIGludGVsX2xl Z2FjeV9zdWJtaXNzaW9uX3Jlc3VtZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Owo+ICAgCj4gICBpbnQgX19tdXN0X2NoZWNrIGludGVsX3JpbmdfY2FjaGVsaW5lX2FsaWduKHN0 cnVjdCBpOTE1X3JlcXVlc3QgKnJxKTsKPiAgIAo+IC1pbnQgaW50ZWxfcmluZ193YWl0X2Zvcl9z cGFjZShzdHJ1Y3QgaW50ZWxfcmluZyAqcmluZywgdW5zaWduZWQgaW50IGJ5dGVzKTsKPiAgIHUz MiBfX211c3RfY2hlY2sgKmludGVsX3JpbmdfYmVnaW4oc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEs IHVuc2lnbmVkIGludCBuKTsKPiAgIAo+ICAgc3RhdGljIGlubGluZSB2b2lkIGludGVsX3Jpbmdf YWR2YW5jZShzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSwgdTMyICpjcykKPiBAQCAtODk1LDE1ICs4 OTQsNiBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaW50ZWxfZW5naW5lX2hhc19zdGFydGVkKHN0cnVj dCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgIHZvaWQgaW50ZWxfZW5naW5lX2dldF9pbnN0 ZG9uZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gICAJCQkgICAgICAgc3RydWN0 IGludGVsX2luc3Rkb25lICppbnN0ZG9uZSk7Cj4gICAKPiAtLyoKPiAtICogQXJiaXRyYXJ5IHNp emUgZm9yIGxhcmdlc3QgcG9zc2libGUgJ2FkZCByZXF1ZXN0JyBzZXF1ZW5jZS4gVGhlIGNvZGUg cGF0aHMKPiAtICogYXJlIGNvbXBsZXggYW5kIHZhcmlhYmxlLiBFbXBpcmljYWwgbWVhc3VyZW1l bnQgc2hvd3MgdGhhdCB0aGUgd29yc3QgY2FzZQo+IC0gKiBpcyBCRFcgYXQgMTkyIGJ5dGVzICg2 ICsgNiArIDM2IGR3b3JkcyksIHRoZW4gSUxLIGF0IDEzNiBieXRlcy4gSG93ZXZlciwKPiAtICog d2UgbmVlZCB0byBhbGxvY2F0ZSBkb3VibGUgdGhlIGxhcmdlc3Qgc2luZ2xlIHBhY2tldCB3aXRo aW4gdGhhdCBlbWlzc2lvbgo+IC0gKiB0byBhY2NvdW50IGZvciB0YWlsIHdyYXBhcm91bmQgKHNv IDYgKyA2ICsgNzIgZHdvcmRzIGZvciBCRFcpLgo+IC0gKi8KPiAtI2RlZmluZSBNSU5fU1BBQ0Vf Rk9SX0FERF9SRVFVRVNUIDMzNgo+IC0KPiAgIHN0YXRpYyBpbmxpbmUgdTMyIGludGVsX2h3c19z ZXFub19hZGRyZXNzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIHsKPiAgIAly ZXR1cm4gZW5naW5lLT5zdGF0dXNfcGFnZS5nZ3R0X29mZnNldCArIEk5MTVfR0VNX0hXU19JTkRF WF9BRERSOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9j a19lbmdpbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2VuZ2luZS5j Cj4gaW5kZXggZDBjNDRjMThkYjQyLi41MGUxYTBiMWFmN2UgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZW5naW5lLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9ja19lbmdpbmUuYwo+IEBAIC0xNDgsOCArMTQ4LDYgQEAg c3RhdGljIHN0cnVjdCBpbnRlbF9yaW5nICptb2NrX3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lKQo+ICAgCWNvbnN0IHVuc2lnbmVkIGxvbmcgc3ogPSBQQUdFX1NJWkUgLyAyOwo+ ICAgCXN0cnVjdCBtb2NrX3JpbmcgKnJpbmc7Cj4gICAKPiAtCUJVSUxEX0JVR19PTihNSU5fU1BB Q0VfRk9SX0FERF9SRVFVRVNUID4gc3opOwo+IC0KPiAgIAlyaW5nID0ga3phbGxvYyhzaXplb2Yo KnJpbmcpICsgc3osIEdGUF9LRVJORUwpOwo+ICAgCWlmICghcmluZykKPiAgIAkJcmV0dXJuIE5V TEw7Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=