From: Sibi Sankar <sibis@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel-owner@vger.kernel.org,
linux-remoteproc-owner@vger.kernel.org
Subject: Re: [PATCH] remoteproc: qcom: pas: Add QCS404 remoteprocs
Date: Wed, 26 Sep 2018 21:18:53 +0530 [thread overview]
Message-ID: <78799383c083420b8109455c463fc730@codeaurora.org> (raw)
In-Reply-To: <20180925233550.GB27436@tuxbook-pro>
On 2018-09-26 05:05, Bjorn Andersson wrote:
> On Tue 25 Sep 03:18 PDT 2018, Sibi Sankar wrote:
>> On 2018-09-20 22:52, Bjorn Andersson wrote:
>> > diff --git a/drivers/remoteproc/qcom_adsp_pil.c
>> > b/drivers/remoteproc/qcom_adsp_pil.c
>> > index da2254ea1135..fcbb816a9698 100644
>> > --- a/drivers/remoteproc/qcom_adsp_pil.c
>> > +++ b/drivers/remoteproc/qcom_adsp_pil.c
>> > @@ -362,10 +362,22 @@ static const struct adsp_data slpi_resource_init =
>> > {
>> > .ssctl_id = 0x16,
>> > };
>> >
>> > +static const struct adsp_data wcss_resource_init = {
>> > + .crash_reason_smem = 421,
>> > + .firmware_name = "wcnss.mdt",
>> > + .pas_id = 6,
>> > + .ssr_name = "mpss",
>> > + .sysmon_name = "wlan",
>>
>> Shouldn't the sysmon name be "wcnss" instead of "wlan"?
>>
>
> I derived this from the downstream kernel, perhaps I got it wrong?
>
I could see that the label is "wcnss" and glink-label is "mpss"
downstream.
> Regards,
> Bjorn
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2018-09-26 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 17:22 [PATCH] remoteproc: qcom: pas: Add QCS404 remoteprocs Bjorn Andersson
2018-09-25 10:18 ` Sibi Sankar
2018-09-25 23:35 ` Bjorn Andersson
2018-09-26 15:48 ` Sibi Sankar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78799383c083420b8109455c463fc730@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc-owner@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.