From: Mark Levedahl <mlevedahl@gmail.com>
To: Johannes Sixt via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH v2 4/6] gitk: use more natural language for labels of color preferences
Date: Thu, 13 Aug 2026 13:00:40 -0400 [thread overview]
Message-ID: <787b9472-d9ac-4d1f-814c-f7be9318ff55@gmail.com> (raw)
In-Reply-To: <45d5b05281cd4f3f43290d128d631a47975225f3.1786540582.git.gitgitgadget@gmail.com>
On 8/12/26 9:16 AM, Johannes Sixt via GitGitGadget wrote:
> markbg markbgcolor {} \
> - [mc "Marked line bg"] \
> + [mc "Marked line background"] \
> [mc "marked line background"] \
>
Not a new issue, but "marked line" is not a good description. What this actually controls
is the background color of commit message text found by search criteria in the gui, not
lines of text, and (as far as I can tell) never any text found in the patch text.
So, perhaps my observation is best deferred as being part of a different topic that would
make the search function highlight all matches, not just those in the commit message.
Mark
next prev parent reply other threads:[~2026-08-13 17:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 6:40 [PATCH 0/5] gitk: make color preferences visually more pleasing and better usable Johannes Sixt via GitGitGadget
2026-08-06 6:40 ` [PATCH 1/5] gitk: set intitial colors of swatches using the available helper Johannes Sixt via GitGitGadget
2026-08-07 14:36 ` mark
2026-08-06 6:40 ` [PATCH 2/5] gitk: condense repetitive code around color buttons into foreach loops Johannes Sixt via GitGitGadget
2026-08-07 14:37 ` mark
2026-08-06 6:40 ` [PATCH 3/5] gitk: show color preferences on the button instead of the label Johannes Sixt via GitGitGadget
2026-08-07 14:37 ` mark
2026-08-08 9:33 ` Johannes Sixt
2026-08-06 6:40 ` [PATCH 4/5] gitk: use more natural language for labels of color preferences Johannes Sixt via GitGitGadget
2026-08-06 6:40 ` [PATCH 5/5] gitk: avoid constructing dialog titles from text pieces Johannes Sixt via GitGitGadget
2026-08-07 14:37 ` mark
2026-08-08 10:00 ` Johannes Sixt
2026-08-08 14:55 ` Mark Levedahl
2026-08-09 7:27 ` Johannes Sixt
2026-08-08 16:32 ` Junio C Hamano
2026-08-09 7:04 ` Johannes Sixt
2026-08-12 13:16 ` [PATCH v2 0/6] gitk: make color preferences visually more pleasing and better usable Johannes Sixt via GitGitGadget
2026-08-12 13:16 ` [PATCH v2 1/6] gitk: set intitial colors of swatches using the available helper Johannes Sixt via GitGitGadget
2026-08-12 13:16 ` [PATCH v2 2/6] gitk: condense repetitive code around color buttons into foreach loops Johannes Sixt via GitGitGadget
2026-08-12 13:16 ` [PATCH v2 3/6] gitk: show color preferences on the button instead of the label Johannes Sixt via GitGitGadget
2026-08-13 17:00 ` Mark Levedahl
2026-08-12 13:16 ` [PATCH v2 4/6] gitk: use more natural language for labels of color preferences Johannes Sixt via GitGitGadget
2026-08-13 17:00 ` Mark Levedahl [this message]
2026-08-13 19:35 ` Johannes Sixt
2026-08-13 20:11 ` Mark Levedahl
2026-08-12 13:16 ` [PATCH v2 5/6] gitk: avoid constructing dialog titles from text pieces Johannes Sixt via GitGitGadget
2026-08-12 13:16 ` [PATCH v2 6/6] gitk: move UI for generic colors above diff colors Johannes Sixt via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=787b9472-d9ac-4d1f-814c-f7be9318ff55@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.