From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hr2.samba.org (hr2.samba.org [144.76.82.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5ECA1E32A2 for ; Fri, 28 Nov 2025 13:35:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=144.76.82.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764336911; cv=none; b=qtpYuf3pjjsHijqmrCliuaAN87c/2BZdjW9F+UJM7p0/PjiEuT+bbVKiV6v+q+FblZXtFILLHMN6muwen4gAo6vLEXs0bRd568sy2jjVennp77CsJ7U2YHdqe7bZCszgx901KyXRa0oDgDWFsN3TTIySKNdOSQXA5u44eX1Noqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764336911; c=relaxed/simple; bh=4K1chYo5y6DmxvfdgS2mEMZsRMnyUIcSpYthukiYBig=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mew8c2IaljD/SMS24zkqmoOyQrqp4PnJmG4iPMhPggc3ZJu/JYsH1YnWkC4L+LbzCMtb9WhMFuVeH9BPYgufzbIu+OyKP+xl5veEC+yn+FxvjPpxv/W6q6poFtac/NInm3MbEaCvUOfv89QW2V9gw3t2pTKvrnQ/GR9PqFOW2S4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=samba.org; spf=pass smtp.mailfrom=samba.org; dkim=pass (3072-bit key) header.d=samba.org header.i=@samba.org header.b=1waGoaLn; arc=none smtp.client-ip=144.76.82.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=samba.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samba.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (3072-bit key) header.d=samba.org header.i=@samba.org header.b="1waGoaLn" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=samba.org; s=42; h=From:Cc:To:Date:Message-ID; bh=S7kIslra5oRThJMYs3BC9tPGj2u/C/aQAgSkpsIeH48=; b=1waGoaLnPs/kyqZ1p3NJAJQKnz rQl+gcxQ8o8tz7wy8tzWnhYfeXVCNArT/xIaEictEnDx7QmWJSJIfRHXg+HXti5S1qXDBTWzGR+dr c1z8jCbs0UgOnDEWPbSiy/imfNFpaooJI2bM/sBksrl6CZZcj/Jii808C+LwfeR7PSmrV6RJoERYU oTNdzjyMK/WqAhhHLgSwXVA31rcDoNqfClt4dDOSELBgXmRXT8JjW3AuglPuzWzLMIuCxqOToTTKu bwAa10ITdgEACQZNNOYNoit6ZuQrv1Z3W57dzlKCdbslJx0u0PLaYaUuJtnhpiftOso+K6iyS7lOB yOuf9bZiadwyme9C+QVWWLKRpcis6nW+aKfUfKZF0b4SWUh24pYGGNbAU2IFjHKAymjW+yWehiCxF clMVf4YYDPmLHrQufau6K9VrIfBxB4rAdI2LJgRnTnaP+3m7xAG11Dg629DcaVUDbv6nm45dxgPAP lw8lXxC8LXUrVcc3tS0Ej3M/; Received: from [127.0.0.2] (localhost [127.0.0.1]) by hr2.samba.org with esmtpsa (TLS1.3:ECDHE_SECP256R1__ECDSA_SECP256R1_SHA256__CHACHA20_POLY1305:256) (Exim) id 1vOyct-00G9An-09; Fri, 28 Nov 2025 13:35:07 +0000 Message-ID: <788d9b9e-e693-437f-bb56-1b84868b4250@samba.org> Date: Fri, 28 Nov 2025 14:35:06 +0100 Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] smb: smbdirect/client/server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks To: Namjae Jeon , Steve French Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, Tom Talpey , Long Li , Paulo Alcantara , David Howells References: Content-Language: en-US From: Stefan Metzmacher In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Am 28.11.25 um 13:11 schrieb Namjae Jeon: > On Fri, Nov 28, 2025 at 7:17 PM Stefan Metzmacher wrote: >> >> Am 28.11.25 um 05:53 schrieb Steve French: >>> On Thu, Nov 27, 2025 at 9:19 PM Namjae Jeon wrote: >>> >>>> On Fri, Nov 28, 2025 at 12:54 AM Stefan Metzmacher >>>> wrote: >>>>> >>>>> Am 26.11.25 um 02:07 schrieb Namjae Jeon: >>>>>> On Wed, Nov 26, 2025 at 8:50 AM Namjae Jeon >>>> wrote: >>>>>>> >>>>>>> On Tue, Nov 25, 2025 at 11:22 PM Stefan Metzmacher >>>> wrote: >>>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> here are some small cleanups for a problem Nanjae reported, >>>>>>>> where two WARN_ON_ONCE(sc->status != ...) checks where triggered >>>>>>>> by a Windows 11 client. >>>>>>>> >>>>>>>> The patches should relax the checks if an error happened before, >>>>>>>> they are intended for 6.18 final, as far as I can see the >>>>>>>> problem was introduced during the 6.18 cycle only. >>>>>>>> >>>>>>>> Given that v1 of this patchset produced a very useful WARN_ONCE() >>>>>>>> message, I'd really propose to keep this for 6.18, also for the >>>>>>>> client where the actual problem may not exists, but if they >>>>>>>> exist, it will be useful to have the more useful messages >>>>>>>> in 6.16 final. >>>>>> Anyway, Applied this patch-set to #ksmbd-for-next-next. >>>>>> Please check the below issue. >>>>> >>>>> Steve, can you move this into ksmbd-for-next? >>>> Steve, There are more patches in ksmbd-for-next-next. >>>> Please apply the following 6 patches in #ksmbd-for-next-next to >>>> #ksmbd-for-next. >>>> >>>> 3858665313f1 (HEAD -> ksmbd-for-next-next, origin/ksmbd-for-next-next) >>>> ksmbd: ipc: fix use-after-free in ipc_msg_send_request >>>> b9c7d4fe6e93 smb: client: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) >>>> checks in recv_done() and smbd_conn_upcall() >>>> 6c5ceb636d08 smb: server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) >>>> checks in recv_done() and smb_direct_cm_handler() >>>> d02a328304e5 smb: smbdirect: introduce >>>> SMBDIRECT_CHECK_STATUS_{WARN,DISCONNECT}() >>>> 340255e842d5 smb: smbdirect: introduce SMBDIRECT_DEBUG_ERR_PTR() helper >>>> 01cba263d1bd ksmbd: vfs: fix race on m_flags in vfs_cache >> >> It seems these are the v2 patches, please use v3, >> the difference is that the __SMBDIRECT_SOCKET_DISCONNECT >> defines are moved up in order to let the patches on top work >> with out modifications. I noticed the difference while >> doing a rebase on ksmbd-for-next and get conflicts. > Right, Sorry for missing v3 patches. > > Steve, Please apply updated 4 patches in ksmbd-for-next-next to ksmbd-for-next. > > fc86cca6087f (HEAD -> ksmbd-for-next-next, origin/ksmbd-for-next-next) > smb: client: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks in > recv_done() and smbd_conn_upcall() > 111b7cb1b7f6 smb: server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) > checks in recv_done() and smb_direct_cm_handler() > 12059ee95a5b smb: smbdirect: introduce > SMBDIRECT_CHECK_STATUS_{WARN,DISCONNECT}() > 3658d5ac7908 smb: smbdirect: introduce SMBDIRECT_DEBUG_ERR_PTR() helper Given that we missed linux-next for this week anyway, we could also add everything from my for-6.19/fs-smb-20251128-v5 branch, which is rebased on smfrench-smb3-kernel/ksmbd-for-next with the top 3 commits replaced by the top 3 commits from smfrench-smb3-kernel/ksmbd-for-next-next. And has the patches from David's cifs-cleanup branch as well as my smbdirect.ko patches. metze