Re: [Buildroot] [PATCH 1/1] package/qt6/qt6opcua: new package

[Andreas Naumann <dev@andin.de>]

Hi Thomas,

On 17.07.24 22:59, Thomas Petazzoni via buildroot wrote:
> Hello Andreas,
...
> 
> Thanks applied, with minor changes, see below.

Thanks for applying and fixing.

> 
>> ---
>>  package/qt6/Config.in              |  1 +
>>  package/qt6/qt6opcua/Config.in     | 14 +++++++++
>>  package/qt6/qt6opcua/qt6opcua.hash |  9 ++++++
>>  package/qt6/qt6opcua/qt6opcua.mk   | 46 ++++++++++++++++++++++++++++++
>>  4 files changed, 70 insertions(+)
> 
> Entry in DEVELOPERS file missing.

ok.

> 
> 
> 
>>  create mode 100644 package/qt6/qt6opcua/Config.in
>>  create mode 100644 package/qt6/qt6opcua/qt6opcua.hash
>>  create mode 100644 package/qt6/qt6opcua/qt6opcua.mk
>>
>> diff --git a/package/qt6/Config.in b/package/qt6/Config.in
>> index e84806d5e4..29c1c25c7f 100644
>> --- a/package/qt6/Config.in
>> +++ b/package/qt6/Config.in
>> @@ -48,6 +48,7 @@ source "package/qt6/qt6core5compat/Config.in"
>>  source "package/qt6/qt6declarative/Config.in"
>>  source "package/qt6/qt6languageserver/Config.in"
>>  source "package/qt6/qt6mqtt/Config.in"
>> +source "package/qt6/qt6opcua/Config.in"
>>  source "package/qt6/qt6serialbus/Config.in"
>>  source "package/qt6/qt6serialport/Config.in"
>>  source "package/qt6/qt6shadertools/Config.in"
>> diff --git a/package/qt6/qt6opcua/Config.in b/package/qt6/qt6opcua/Config.in
>> new file mode 100644
>> index 0000000000..84a51f544f
>> --- /dev/null
>> +++ b/package/qt6/qt6opcua/Config.in
>> @@ -0,0 +1,14 @@
>> +config BR2_PACKAGE_QT6OPCUA
>> +	bool "qt6opcua"
>> +	select BR2_PACKAGE_QT6BASE_NETWORK
>> +        # qt6opcuda needs host-qt6opcua, and host-qt6opcua needs
>> +        # network support in qt6base.
> 
> Dang, I realize now the indentation here is with spaces, it should have
> been with tabs. I'll fix that up.

Damn, i was using some copypasta and was relying on check-package to
complain.

> 
> 
>> +QT6OPCUA_LICENSE = \
>> +	GPL-2.0 or GPL-3.0 or LGPL-3.0, \
>> +	GPL-3.0 WITH Qt-GPL-exception-1.0 (tools), \
> 
> The tools are also under "GPL-2.0 or GPL-3.0 or LGPL-3.0" as far I can
> see, so I dropped this line.

Thanks for checking. And was not very confident in how to reliably get
this information. Basically I tried to reflect the contents of
licenseRule.json.


regards,
Andreas


> 
> Thanks!
> 
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot