From: Martin KaFai Lau <martin.lau@linux.dev>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
eddyz87@gmail.com, mykolal@fb.com, song@kernel.org,
yonghong.song@linux.dev, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
jolsa@kernel.org, shuah@kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v1 1/2] bpf: changes_pkt_data: correct the 'main' error
Date: Tue, 11 Feb 2025 12:06:13 -0800 [thread overview]
Message-ID: <78987b29-44e2-4318-a6a5-391b7cd76a16@linux.dev> (raw)
In-Reply-To: <CAL+tcoA2wV1CvAV1TZAvrRuxOntb0fEDpgOsC2-FVtYr-go=1w@mail.gmail.com>
On 2/6/25 10:48 PM, Jason Xing wrote:
> On Fri, Feb 7, 2025 at 2:04 PM Martin KaFai Lau <martin.lau@linux.dev> wrote:
>>
>> On 2/3/25 6:39 PM, Jason Xing wrote:
>>> When compiling the selftests, the following error is printed out:
>>> selftests/bpf/prog_tests/changes_pkt_data.c: In function ‘test_aux’:
>>> selftests/bpf/prog_tests/changes_pkt_data.c:22:27: error: ‘main’ is usually a function [-Werror=main]
>>> struct changes_pkt_data *main = NULL;
>>
>> The bpf CI has been testing this piece with different compilers. I also don't
>> see it in my environment. How to reproduce it and which compiler?
>
> The gcc version is "gcc version 8.5.0" which is an old one. Yep, there
gcc 8.5 is old. I don't even know if it supports compiling the bpf prog in the
bpf selftests. Please update the compiler.
next prev parent reply other threads:[~2025-02-11 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 2:39 [PATCH bpf-next v1 0/2] selftests: fix two small compilation errors Jason Xing
2025-02-04 2:39 ` [PATCH bpf-next v1 1/2] bpf: changes_pkt_data: correct the 'main' error Jason Xing
2025-02-07 6:04 ` Martin KaFai Lau
2025-02-07 6:48 ` Jason Xing
2025-02-11 20:06 ` Martin KaFai Lau [this message]
2025-02-04 2:39 ` [PATCH bpf-next v1 2/2] bpf: sockopt_sk: fix 'undeclared' definition error Jason Xing
2025-02-05 2:57 ` Hou Tao
2025-02-05 3:27 ` Jason Xing
2025-02-05 9:30 ` Hou Tao
2025-02-05 9:38 ` Jason Xing
2025-02-11 19:40 ` Martin KaFai Lau
[not found] ` <81c94bf316ea2971f3454e32fdeae4061919458241f6f4c2c80cb0f20d06f144@mail.kernel.org>
[not found] ` <CAL+tcoAUKArVkV_O2nv-D_K8qiRm6W3YkDe8=rUrGbxUxJmqmg@mail.gmail.com>
2025-02-06 10:21 ` [PATCH bpf-next v1 0/2] selftests: fix two small compilation errors Daniel Xu
2025-02-06 12:13 ` Jason Xing
2025-02-11 7:52 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78987b29-44e2-4318-a6a5-391b7cd76a16@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mykolal@fb.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.