From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Joseph, Anoob" <Anoob.Joseph@caviumnetworks.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>,
dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues
Date: Mon, 8 Oct 2018 13:35:34 +0100 [thread overview]
Message-ID: <789e1a1a-aa7b-8aa0-41b9-ce188eeccc6b@intel.com> (raw)
In-Reply-To: <98620a3a-2968-be0b-4690-ee4d6dad1101@caviumnetworks.com>
On 10/8/2018 12:29 PM, Joseph, Anoob wrote:
> Hi Ferruh,
>
> On 08-10-2018 16:30, Ferruh Yigit wrote:
>> External Email
>>
>> On 10/8/2018 11:41 AM, Anoob Joseph wrote:
>>> This patchset fixes multiple issues reported by checkpatch in l2fwd
>>> code base. These issues would be flagged for any new copy of the file
>>> and hence, fixing at the source.
>>>
>>> Anoob Joseph (8):
>>> examples/l2fwd: remove quoted white space before newline
>>> examples/l2fwd: need space between two args
>>> examples/l2fwd: else should follow close brace
>>> examples/l2fwd: replace bare usage of 'unsigned'
>>> examples/l2fwd: follow convention for block comments
>>> examples/l2fwd: limit line to 80 char
>>> examples/l2fwd: space required between elements
>>> examples/l2fwd: remove null initialisation
>> Hi Anoob,
>>
>> I am not sure if it is good idea to get syntax only fixes, I would prefer to get
>> syntax fixes when some other code touches that area.
> I'm preparing a new copy of l2fwd with support for eventmode(as
> suggested in,
> https://mails.dpdk.org/archives/dev/2018-August/109717.html). All these
> issues were flagged when I did the copy. What would be the better
> approach in that case? Fix it in just the new application or fix the
> source? Fixing in just the new app would mean, the two versions will
> have a diff at the time of copy.
I see, make sense to not create syntax diff copied and original versions, I
missed the new copy part. So OK for this patch.
next prev parent reply other threads:[~2018-10-08 12:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 10:41 [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues Anoob Joseph
2018-10-08 10:41 ` [PATCH 1/8] examples/l2fwd: remove quoted white space before newline Anoob Joseph
2018-10-08 10:41 ` [PATCH 2/8] examples/l2fwd: need space between two args Anoob Joseph
2018-10-08 10:41 ` [PATCH 3/8] examples/l2fwd: else should follow close brace Anoob Joseph
2018-10-08 10:41 ` [PATCH 4/8] examples/l2fwd: replace bare usage of 'unsigned' Anoob Joseph
2018-10-08 10:41 ` [PATCH 5/8] examples/l2fwd: follow convention for block comments Anoob Joseph
2018-10-08 10:41 ` [PATCH 6/8] examples/l2fwd: limit line to 80 char Anoob Joseph
2018-10-08 10:41 ` [PATCH 7/8] examples/l2fwd: space required between elements Anoob Joseph
2018-10-08 10:41 ` [PATCH 8/8] examples/l2fwd: remove null initialisation Anoob Joseph
2018-10-08 11:00 ` [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues Ferruh Yigit
2018-10-08 11:29 ` Joseph, Anoob
2018-10-08 12:35 ` Ferruh Yigit [this message]
2018-10-29 2:19 ` Thomas Monjalon
2018-10-29 4:48 ` Joseph, Anoob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=789e1a1a-aa7b-8aa0-41b9-ce188eeccc6b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Anoob.Joseph@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narayanaprasad.athreya@caviumnetworks.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.