All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Laguna, Lukasz" <lukasz.laguna@intel.com>
To: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>,
	<igt-dev@lists.freedesktop.org>
Cc: Adam Miszczak <adam.miszczak@linux.intel.com>,
	Jakub Kolakowski <jakub1.kolakowski@intel.com>,
	Michal Wajdeczko <michal.wajdeczko@intel.com>,
	 Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
Subject: Re: [PATCH i-g-t] tests/intel/xe_sriov_flr: Skip media GTs when reading LMEM provisioning
Date: Thu, 28 Aug 2025 12:25:17 +0200	[thread overview]
Message-ID: <78ababa0-6910-49b8-9dc3-7efdfda8353c@intel.com> (raw)
In-Reply-To: <20250826192555.465679-1-marcin.bernatowicz@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]


On 8/26/2025 21:25, Marcin Bernatowicz wrote:
> LMEM provisioning is exposed only on the primary GT.
> Media GTs do not provide LMEM provisioning data,
> so attempting to read it there caused the subtest to skip.
> Restrict iteration to non-media GTs before reading LMEM provisioning.
>
> Signed-off-by: Marcin Bernatowicz<marcin.bernatowicz@linux.intel.com>
> Cc: Adam Miszczak<adam.miszczak@linux.intel.com>
> Cc: Jakub Kolakowski<jakub1.kolakowski@intel.com>
> Cc: Lukasz Laguna<lukasz.laguna@intel.com>
> Cc: Michal Wajdeczko<michal.wajdeczko@intel.com>
> Cc: Satyanarayana K V P<satyanarayana.k.v.p@intel.com>
> ---
>   tests/intel/xe_sriov_flr.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tests/intel/xe_sriov_flr.c b/tests/intel/xe_sriov_flr.c
> index fc08703c0..248dcf6fb 100644
> --- a/tests/intel/xe_sriov_flr.c
> +++ b/tests/intel/xe_sriov_flr.c
> @@ -813,6 +813,9 @@ static int populate_vf_lmem_sizes(struct subcheck_data *data)
>   	igt_assert(ldata->vf_lmem_size);
>   
>   	xe_for_each_gt(data->pf_fd, gt) {
> +		if (xe_is_media_gt(data->pf_fd, gt))

This data is available only for the main GT, so I would suggest changing 
the condition to |!xe_is_main_gt()|. That way it also covers potential 
other non-main GT types in the future.

> +			continue;
> +
>   		ret = xe_sriov_pf_debugfs_read_provisioned_ranges(data->pf_fd,
>   								  XE_SRIOV_SHARED_RES_LMEM,
>   								  gt, &ranges, &nr_ranges);

[-- Attachment #2: Type: text/html, Size: 2532 bytes --]

      parent reply	other threads:[~2025-08-28 10:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26 19:25 [PATCH i-g-t] tests/intel/xe_sriov_flr: Skip media GTs when reading LMEM provisioning Marcin Bernatowicz
2025-08-26 20:40 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-08-26 20:53 ` ✓ i915.CI.BAT: " Patchwork
2025-08-27  6:44 ` ✓ Xe.CI.Full: " Patchwork
2025-08-27  7:55 ` ✗ i915.CI.Full: failure " Patchwork
2025-08-27  7:59 ` [PATCH i-g-t] " Adam Miszczak
2025-08-28 10:25 ` Laguna, Lukasz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78ababa0-6910-49b8-9dc3-7efdfda8353c@intel.com \
    --to=lukasz.laguna@intel.com \
    --cc=adam.miszczak@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jakub1.kolakowski@intel.com \
    --cc=marcin.bernatowicz@linux.intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=satyanarayana.k.v.p@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.