From: Alejandro Colomar <alx@kernel.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: "A. Wilcox" <AWilcox@wilcox-tech.com>,
libc-coord@lists.openwall.com,
Jonathan Wakely <jwakely@redhat.com>,
Rich Felker <dalias@libc.org>,
linux-man@vger.kernel.org, libc-alpha@sourceware.org,
musl@lists.openwall.com, Sam James <sam@gentoo.org>,
Szabolcs Nagy <nsz@port70.net>, Jakub Wilk <jwilk@jwilk.net>
Subject: Re: [musl] Re: [libc-coord] Re: regression in man pages for interfaces using loff_t
Date: Sat, 8 Jul 2023 19:03:23 +0200 [thread overview]
Message-ID: <78b648da-dde7-d331-7384-03214b977e6d@kernel.org> (raw)
In-Reply-To: <0101bd69-1c8d-dcf2-f60d-ff5a984b7566@cs.ucla.edu>
[-- Attachment #1.1: Type: text/plain, Size: 1286 bytes --]
Hi all,
On 7/3/23 23:35, Paul Eggert wrote:
> On 2023-07-03 11:16, Jakub Wilk wrote:
>>> -This format is employed in cases where only a single
>>> -feature test macro can be used to expose the function
>>> -declaration, and that macro is not defined by default.
>>> +This format is employed in cases where feature macros
>>> +expose the function declaration with the correct type,
>>> +and these macros are not defined by default.
>>
>> This isn't right. The shorthand format is sometimes used when there's
>> no off(64)_t involved, e.g. in memfd_create(2).
>
> Fair enough. Let's improve that wording to:
>
> This format is employed when the feature test macros ensure that the
> proper function declarations are visible, and the macros are not defined
> by default.
>
> Revised patch attached. If this wording is still not clear enough,
> please feel free to suggest better wording.
Thanks for the v3 patch, Paul. I like it. Would you mind resending it
inline, to make it easier to quote-reply to it, in case anyone wants
to discuss anything? Does anyone oppose to this patch, and wants to
propose an alternative patch?
Cheers,
Alex
--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-07-08 17:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 17:53 regression in man pages for interfaces using loff_t Rich Felker
2023-06-28 18:21 ` Paul Eggert
2023-06-28 19:15 ` Rich Felker
2023-06-30 7:11 ` Paul Eggert
[not found] ` <CACb0b4nkLFOi4q=SSBSD_7aH4FRt9H4sRHQz6wF5O-x9PiwnFA@mail.gmail.com>
2023-06-30 8:14 ` [libc-coord] " Jonathan Wakely
2023-06-30 8:30 ` Sam James
2023-06-30 19:44 ` Paul Eggert
[not found] ` <9751E98E-025B-4E32-9EDF-D1984F998C10@wilcox-tech.com>
2023-07-02 19:21 ` [musl] " Paul Eggert
2023-07-03 18:16 ` Jakub Wilk
2023-07-03 21:35 ` Paul Eggert
2023-07-08 17:03 ` Alejandro Colomar [this message]
2023-07-09 6:07 ` [PATCH v4] off64_t: prefer off_t for splice, etc Paul Eggert
2023-07-09 6:16 ` [libc-coord] " Sam James
2023-07-15 15:08 ` Alejandro Colomar
2023-07-15 18:35 ` [musl] " Rich Felker
2023-07-15 20:01 ` Paul Eggert
2023-07-16 0:35 ` Alejandro Colomar
2023-07-16 0:39 ` Alejandro Colomar
2023-06-30 23:37 ` [musl] Re: regression in man pages for interfaces using loff_t Rich Felker
2023-07-01 7:24 ` [libc-coord] " Paul Eggert
2023-07-01 13:36 ` Szabolcs Nagy
2023-07-01 23:02 ` Paul Eggert
2023-07-01 14:32 ` [musl] " Rich Felker
2023-07-01 18:45 ` Alejandro Colomar
2023-07-01 23:06 ` Paul Eggert
2023-06-28 19:19 ` Szabolcs Nagy
2023-06-28 19:28 ` [musl] " Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78b648da-dde7-d331-7384-03214b977e6d@kernel.org \
--to=alx@kernel.org \
--cc=AWilcox@wilcox-tech.com \
--cc=dalias@libc.org \
--cc=eggert@cs.ucla.edu \
--cc=jwakely@redhat.com \
--cc=jwilk@jwilk.net \
--cc=libc-alpha@sourceware.org \
--cc=libc-coord@lists.openwall.com \
--cc=linux-man@vger.kernel.org \
--cc=musl@lists.openwall.com \
--cc=nsz@port70.net \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.