From: David Ahern <dsahern@kernel.org>
To: Antony Antony <antony.antony@secunet.com>,
Jakub Kicinski <kuba@kernel.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
netdev@vger.kernel.org
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Shuah Khan <shuah@kernel.org>,
devel@linux-ipsec.org, Tobias Brunner <tobias@strongswan.org>,
Simon Horman <horms@kernel.org>,
Sabrina Dubroca <sd@queasysnail.net>,
stable+noautosel@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 1/2] icmp: fix ICMP error source address when xfrm policy matches
Date: Thu, 26 Feb 2026 09:18:47 -0700 [thread overview]
Message-ID: <78b7e776-5e1e-4cbf-96ed-ece9549e5caa@kernel.org> (raw)
In-Reply-To: <19a0156ff6e76baa323a81d710510d399a6ff63a.1772101380.git.antony.antony@secunet.com>
On 2/26/26 3:27 AM, Antony Antony wrote:
> When an IPsec gateway generates an ICMP error (e.g., Destination Host
> Unreachable), the source address incorrectly shows the unreachable
> destination instead of the gateway's address. IPv6 behaves correctly.
>
> Before fix:
> ping 10.1.6.3
> From 10.1.6.3 icmp_seq=1 Destination Host Unreachable
> (wrong - 10.1.6.3 is the unreachable host)
>
> After fix:
> ping 10.1.6.3
> From 10.1.5.2 icmp_seq=1 Destination Host Unreachable
> (correct - 10.1.5.2 is the gateway)
>
> The fix removes the memcpy that overwrote fl4 with fl4_dec after
> xfrm_lookup(). A follow-up commit adds a selftest.
>
> Fixes: 415b3334a21a ("icmp: Fix regression in nexthop resolution during replies.")
> Cc: stable+noautosel@kernel.org # Avoid false positives in tests
> Signed-off-by: Antony Antony <antony.antony@secunet.com>
> Acked-by: Tobias Brunner <tobias@strongswan.org>
> ---
> net/ipv4/icmp.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2026-02-26 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 10:29 [PATCH net-next v5 0/2] icmp: Fix icmp error source address over xfrm tunnel Antony Antony
2026-02-26 10:27 ` [PATCH net-next v5 1/2] icmp: fix ICMP error source address when xfrm policy matches Antony Antony
2026-02-26 16:18 ` David Ahern [this message]
2026-02-26 10:28 ` [PATCH net-next v5 2/2] selftests: net: add ICMP error source address test over xfrm tunnel Antony Antony
2026-02-26 13:51 ` [devel-ipsec] [PATCH net-next v5 0/2] icmp: Fix icmp error source address " Paul Wouters
2026-02-28 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78b7e776-5e1e-4cbf-96ed-ece9549e5caa@kernel.org \
--to=dsahern@kernel.org \
--cc=antony.antony@secunet.com \
--cc=davem@davemloft.net \
--cc=devel@linux-ipsec.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=shuah@kernel.org \
--cc=stable+noautosel@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tobias@strongswan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.