From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>,
Rob Herring <robh@kernel.org>
Cc: konrad.dybcio@linaro.org, andersson@kernel.org,
andi.shyti@kernel.org, linux-arm-msm@vger.kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, conor+dt@kernel.org,
agross@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org,
linux@treblig.org, dan.carpenter@linaro.org, Frank.Li@nxp.com,
konradybcio@kernel.org, bryan.odonoghue@linaro.org,
krzk+dt@kernel.org, quic_vdadhani@quicinc.com
Subject: Re: [PATCH v4 1/4] dt-bindindgs: i2c: qcom,i2c-geni: Document shared flag
Date: Fri, 29 Nov 2024 16:12:39 +0100 [thread overview]
Message-ID: <78cd2bf3-d4e3-4da9-9a92-91ec15475071@kernel.org> (raw)
In-Reply-To: <8ea18a1d-1ba5-47b4-9fb6-343be3b2b26a@quicinc.com>
On 29/11/2024 15:43, Mukesh Kumar Savaliya wrote:
>> But most important: I keep repeating this over and over - NAK for some
>> specific "shared-se" flag, different for each of your IP blocks. Come
>> with something generic for entire qualcomm. There are few of such flags
>> already and there are some patches adding it in different flavors.
>>
> we do have SE (serial engine) which works for i2c, spi, uart, i3c. And
> SE is single HW entity as you are aware of. But I feel it makes sense to
> keep this flag name per SE and even for SPI OR I3C we should be using
> same flag name in DTSI.
>> Get this consistent.
>>
>> NAK for this and v5 doing exactly theh same.
>>
> Hope i meet expectations considering all your suggestions and past
> learning and not missing anything out of my mind.
>
Nothing from my comment above was resolved. I will NAK the next version
as well for the same reasons.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-29 15:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 16:14 [PATCH v4 0/4] Enable shared SE support over I2C Mukesh Kumar Savaliya
2024-11-13 16:14 ` [PATCH v4 1/4] dt-bindindgs: i2c: qcom,i2c-geni: Document shared flag Mukesh Kumar Savaliya
2024-11-15 17:31 ` Rob Herring
2024-11-17 17:45 ` Mukesh Kumar Savaliya
2024-11-25 8:11 ` Krzysztof Kozlowski
2024-11-29 14:43 ` Mukesh Kumar Savaliya
2024-11-29 15:12 ` Krzysztof Kozlowski [this message]
2024-11-13 16:14 ` [PATCH v4 2/4] dmaengine: gpi: Add Lock and Unlock TRE support to access I2C exclusively Mukesh Kumar Savaliya
2024-11-15 19:23 ` Konrad Dybcio
2024-11-18 5:46 ` Mukesh Kumar Savaliya
2024-11-22 13:40 ` Konrad Dybcio
2024-11-25 5:01 ` Mukesh Kumar Savaliya
2024-11-13 16:14 ` [PATCH v4 3/4] soc: qcom: geni-se: Do not keep GPIOs to sleep state for shared SE usecase Mukesh Kumar Savaliya
2024-11-13 16:14 ` [PATCH v4 4/4] i2c: i2c-qcom-geni: Enable i2c controller sharing between two subsystems Mukesh Kumar Savaliya
2024-11-15 19:28 ` Konrad Dybcio
2024-11-18 5:45 ` Mukesh Kumar Savaliya
2024-11-22 13:42 ` Konrad Dybcio
2024-11-25 5:26 ` Mukesh Kumar Savaliya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78cd2bf3-d4e3-4da9-9a92-91ec15475071@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.