From: "Farber, Eliav" <farbere@amazon.com>
To: Marc Zyngier <maz@kernel.org>
Cc: "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"bhe@redhat.com" <bhe@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chocron, Jonathan" <jonnyc@amazon.com>
Subject: RE: [PATCH] arm64: kexec: Check if IRQ is already masked before masking
Date: Wed, 27 Nov 2024 15:18:37 +0000 [thread overview]
Message-ID: <78d8b93342124112bd4a9b64d9a93020@amazon.com> (raw)
> Maybe a slightly better approach would be to simplify this code for something that actually uses the kernel infrastructure:
>
> diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
> index 82e2203d86a31..9b48d952df3ec 100644
> --- a/arch/arm64/kernel/machine_kexec.c
> +++ b/arch/arm64/kernel/machine_kexec.c
> @@ -230,11 +230,8 @@ static void machine_kexec_mask_interrupts(void)
> chip->irq_eoi)
> chip->irq_eoi(&desc->irq_data);
>
> - if (chip->irq_mask)
> - chip->irq_mask(&desc->irq_data);
> -
> - if (chip->irq_disable && !irqd_irq_disabled(&desc->irq_data))
> - chip->irq_disable(&desc->irq_data);
> + irq_set_status_flags(i, IRQ_DISABLE_UNLAZY);
> + irq_disable(desc);
> }
> }
>
> This is of course untested.
I tested your suggested approach and it works.
I will publish V2 for this change.
Thanks, Eliav
next reply other threads:[~2024-11-27 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 15:18 Farber, Eliav [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-11-26 5:05 [PATCH] arm64: kexec: Check if IRQ is already masked before masking Eliav Farber
2024-11-26 18:23 ` Marc Zyngier
2024-11-27 14:58 ` Farber, Eliav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78d8b93342124112bd4a9b64d9a93020@amazon.com \
--to=farbere@amazon.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.