From: Dave Jiang <dave.jiang@intel.com>
To: Xichao Zhao <zhao.xichao@vivo.com>,
dave@stgolabs.net, jonathan.cameron@huawei.com,
alison.schofield@intel.com, vishal.l.verma@intel.com,
ira.weiny@intel.com, dan.j.williams@intel.com
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxl/hdm: Use str_plural() to simplify the code
Date: Tue, 12 Aug 2025 17:01:57 -0700 [thread overview]
Message-ID: <78ebb53e-5cb3-4a6f-b2da-dd37e952a333@intel.com> (raw)
In-Reply-To: <20250811122519.543554-1-zhao.xichao@vivo.com>
On 8/11/25 5:25 AM, Xichao Zhao wrote:
> Use the string choice helper function str_plural() to simplify the code.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
applied to cxl/next
22fb4ad89885
> ---
> drivers/cxl/core/hdm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index e9e1d555cec6..37176c0a781f 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -197,7 +197,7 @@ struct cxl_hdm *devm_cxl_setup_hdm(struct cxl_port *port,
> */
> if (should_emulate_decoders(info)) {
> dev_dbg(dev, "Fallback map %d range register%s\n", info->ranges,
> - info->ranges > 1 ? "s" : "");
> + str_plural(info->ranges));
> cxlhdm->decoder_count = info->ranges;
> }
>
prev parent reply other threads:[~2025-08-13 0:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 12:25 [PATCH] cxl/hdm: Use str_plural() to simplify the code Xichao Zhao
2025-08-11 15:49 ` Dave Jiang
2025-08-12 0:14 ` Alison Schofield
2025-08-13 0:01 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78ebb53e-5cb3-4a6f-b2da-dd37e952a333@intel.com \
--to=dave.jiang@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=zhao.xichao@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.