From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Teddy Astie <teddy.astie@vates.tech>, xen-devel@lists.xenproject.org
Cc: "Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Paul Durrant" <paul@xen.org>
Subject: Re: [XEN PATCH v2] x86/hvm: Use constants for x86 modes
Date: Wed, 4 Dec 2024 13:01:47 +0000 [thread overview]
Message-ID: <79004c19-7e55-4623-86e6-badd165b1d30@citrix.com> (raw)
In-Reply-To: <bf7146a8ccbf05ddc74d4f451a5fa586309b9a50.1733132729.git.teddy.astie@vates.tech>
On 02/12/2024 9:49 am, Teddy Astie wrote:
> In many places of x86 HVM code, constants integer are used to indicate in what mode is
> running the CPU (real, vm86, 16-bits, 32-bits, 64-bits). However, these constants are
> are written directly as integer which hides the actual meaning of these modes.
>
> This patch introduces X86_MODE_* macros and replace those occurences with it.
>
> Signed-off-by Teddy Astie <teddy.astie@vates.tech>
As fed back previously, these are (mostly) not modes.
"Mode" has a specific meaning in the x86 architecture which is not
this. You are going to have to change your commit message, and choice
of constant names.
~Andrew
next prev parent reply other threads:[~2024-12-04 13:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 9:49 [XEN PATCH v2] x86/hvm: Use constants for x86 modes Teddy Astie
2024-12-04 11:10 ` Jan Beulich
2024-12-04 13:01 ` Andrew Cooper [this message]
2024-12-05 18:02 ` Teddy Astie
2024-12-18 15:54 ` Andrew Cooper
2024-12-18 16:23 ` Andrew Cooper
2024-12-18 16:56 ` Andrew Cooper
2024-12-18 17:08 ` [PATCH v3] " Andrew Cooper
2024-12-19 8:18 ` Jan Beulich
2024-12-19 10:46 ` Teddy Astie
2024-12-19 11:35 ` Andrew Cooper
2024-12-19 13:04 ` Teddy Astie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79004c19-7e55-4623-86e6-badd165b1d30@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=teddy.astie@vates.tech \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.