All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Sven Eckelmann <sven@narfation.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batctl: Fix static buffer for resolved mac adddress
Date: Sat, 26 Oct 2013 22:05:21 +0800	[thread overview]
Message-ID: <7905615.ZaMoS6h0AM@diderot> (raw)
In-Reply-To: <1381852869-2104-1-git-send-email-sven@narfation.org>

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

On Tuesday 15 October 2013 18:01:08 Sven Eckelmann wrote:
> The resolve_mac_* functions are currently not reentrant-safe because they
> are using ether_aton. Thus all functions returning a mac address in a
> similar way must also ensure that their data is in a statically allocated
> buffer and not on a stack.
> 
> resolve_mac_from_cache did that for the wrong buffer.
> 
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
>  functions.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied in revision ef41a8d.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

      parent reply	other threads:[~2013-10-26 14:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15 16:01 [B.A.T.M.A.N.] [PATCH 1/2] batctl: Fix static buffer for resolved mac adddress Sven Eckelmann
2013-10-15 16:01 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: Finish resolving of mac address early Sven Eckelmann
2013-10-26 14:06   ` Marek Lindner
2013-10-26 14:05 ` Marek Lindner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7905615.ZaMoS6h0AM@diderot \
    --to=mareklindner@neomailbox.ch \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.