All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Stephan Mueller <smueller@chronox.de>
Cc: dhowells@redhat.com, Eric Biggers <ebiggers3@gmail.com>,
	keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	mathew.j.martineau@linux.intel.com,
	Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH 0/5] KEYS: fixes for new keyctl_dh_compute() KDF extension
Date: Fri, 28 Apr 2017 16:53:00 +0100	[thread overview]
Message-ID: <791.1493394780@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170420054633.14572-1-ebiggers3@gmail.com>

Stephan,

Eric Biggers <ebiggers3@gmail.com> wrote:

> This patch series fixes several bugs in the KDF extension to
> keyctl_dh_compute() currently sitting in keys-next: a way userspace could
> cause an infinite loop, two ways userspace could cause the use of
> uninitialized memory, a misalignment, and missing __user annotations.

Do you want to ack these or do they need fixing?

David

  parent reply	other threads:[~2017-04-28 15:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20  5:46 [PATCH 0/5] KEYS: fixes for new keyctl_dh_compute() KDF extension Eric Biggers
2017-04-20  5:46 ` [PATCH 1/5] KEYS: DH: forbid using digest_null as the KDF hash Eric Biggers
2017-04-20  5:46 ` [PATCH 2/5] KEYS: DH: don't feed uninitialized "otherinfo" into KDF Eric Biggers
2017-04-20  5:46 ` [PATCH 3/5] KEYS: DH: don't feed uninitialized result memory " Eric Biggers
2017-04-20 13:27   ` Stephan Müller
2017-04-20 17:46     ` Eric Biggers
2017-04-20 18:38       ` Stephan Müller
2017-04-21  3:44         ` Eric Biggers
2017-04-27 15:15           ` David Howells
2017-04-28  5:26             ` Eric Biggers
2017-04-20  5:46 ` [PATCH 4/5] KEYS: DH: ensure the KDF counter is properly aligned Eric Biggers
2017-04-20  5:46 ` [PATCH 5/5] KEYS: DH: add __user annotations to keyctl_kdf_params Eric Biggers
2017-04-28 15:53 ` David Howells [this message]
2017-04-28 15:56   ` [PATCH 0/5] KEYS: fixes for new keyctl_dh_compute() KDF extension Stephan Müller
2017-05-01 14:52   ` Stephan Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=791.1493394780@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=ebiggers3@gmail.com \
    --cc=ebiggers@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=smueller@chronox.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.