From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH V2 0/2] block: remove unnecessary RESTART To: Ming Lei , linux-block@vger.kernel.org, Christoph Hellwig Cc: Omar Sandoval , Bart Van Assche , Roman Pen , Hannes Reinecke References: <20171027044330.11921-1-ming.lei@redhat.com> From: Jens Axboe Message-ID: <7921fc66-16de-200b-cc0f-02cf52ef9002@kernel.dk> Date: Tue, 31 Oct 2017 14:29:32 -0600 MIME-Version: 1.0 In-Reply-To: <20171027044330.11921-1-ming.lei@redhat.com> Content-Type: text/plain; charset=utf-8 List-ID: On 10/26/2017 10:43 PM, Ming Lei wrote: > Hi Jens, > > The 1st patch removes the RESTART for TAG-SHARED because SCSI handles it > by itself, and not necessary to waste CPU to do the expensive RESTART. > And Roman Pen reported that this RESTART cuts half of IOPS in his case. > > The 2nd patch removes the RESTART when .get_budget returns BLK_STS_RESOURCE, > and this RESTART is handled by SCSI's RESTART(scsi_end_request()) too. What base is this against? -- Jens Axboe