From: Martin Wilck <martin.wilck@suse.com>
To: "bmarzins@redhat.com" <bmarzins@redhat.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [dm-devel] [PATCH 3/4] libmultipath: use regular array for field widths
Date: Fri, 21 Oct 2022 20:12:51 +0000 [thread overview]
Message-ID: <7922795ac7e0f7686296d518d215b0a077bbdf46.camel@suse.com> (raw)
In-Reply-To: <20221021175150.GD19568@octiron.msp.redhat.com>
On Fri, 2022-10-21 at 12:51 -0500, Benjamin Marzinski wrote:
> On Fri, Oct 21, 2022 at 07:04:55AM +0000, Martin Wilck wrote:
> > On Tue, 2022-10-11 at 16:53 -0500, Benjamin Marzinski wrote:
> > > We know the size of these arrays, so we can just allocate them on
> > > the
> > > stack. Also, show_path() doesn't use the width, so don't
> > > initialize
> > > it
> > > in the first place.
> > >
> > > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> >
> > This isn't wrong, but I'm not sure what it actually achieves except
> > a
> > few less NULL checks (I'm sure you're aware that this doesn't mean
> > better protection against out-of-memory situations). It comes at
> > the
> > cost of an ABI change. I understand that the intention is to
> > eliminate
> > __attribute__((cleanup())). But if we agree we don't want to do
> > that
> > everywhere, I see no particular reason to do it in this code path.
> >
> > I'm not totally against it, but I'm not enthusiastic, either.
>
> That's fine. How about I send a patch to just fix show_path().
Yes, please.
Martin
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-10-21 20:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 21:52 [dm-devel] [PATCH 0/4] remove dangerous cleanup __attribute__ uses Benjamin Marzinski
2022-10-11 21:53 ` [dm-devel] [PATCH 1/4] libmultipath: don't print garbage keywords Benjamin Marzinski
2022-10-21 7:05 ` Martin Wilck
2022-10-11 21:53 ` [dm-devel] [PATCH 2/4] libmultipath: avoid STRBUF_ON_STACK with cancellation points Benjamin Marzinski
2022-10-11 21:53 ` [dm-devel] [PATCH 3/4] libmultipath: use regular array for field widths Benjamin Marzinski
2022-10-21 7:04 ` Martin Wilck
2022-10-21 17:51 ` Benjamin Marzinski
2022-10-21 20:12 ` Martin Wilck [this message]
2022-10-11 21:53 ` [dm-devel] [PATCH 4/4] libmultipath: avoid cleanup __attribute__ with cancellation points Benjamin Marzinski
2022-10-20 16:03 ` [dm-devel] [PATCH 0/4] remove dangerous cleanup __attribute__ uses Martin Wilck
2022-10-20 22:57 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7922795ac7e0f7686296d518d215b0a077bbdf46.camel@suse.com \
--to=martin.wilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.