Re: [LTP] [PATCH] mmap/munmap /dev/zero

[CAI Qian <caiqian@redhat.com>]

----- "Garrett Cooper" <yanegomi@gmail.com> wrote:

> On Tue, Oct 12, 2010 at 12:15 PM, Mike Frysinger <vapier@gentoo.org>
> wrote:
> > On Tuesday, October 12, 2010 10:07:16 CAI Qian wrote:
> >> +/* main setup function of test */
> >> +void setup();
> >> +/* cleanup function for the test */
> >> +void cleanup();
> >> +int mmapzero();
> 
> ...
> 
>     +1 to what Mike said, but in all actually what is the purpose of
> this test? There isn't a description either in the commit message or
> the code itself that mentions what this code should functionally do.
> We need both in order for the code to be committed (otherwise folks
> will play the "WTF does this code do?" game when semantics change a
> few years later in the GNU/Linux world).
> Thanks,
Fixed in v2.
> -Garrett

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list