From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Wed, 15 Jan 2020 08:43:22 -0500 (EST) Subject: [Cluster-devel] [PATCH] gfs2: Avoid access time trashing in gfs2_inode_lookup In-Reply-To: <20200115083040.32714-1-agruenba@redhat.com> References: <20200115083040.32714-1-agruenba@redhat.com> Message-ID: <793501366.2644404.1579095802763.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- > In gfs2_inode_lookup, we initialize inode->i_atime to the lowest > possibly value after gfs2_inode_refresh may already have been called. > This should be the other way around, but we didn't notice because > usually the inode type is known from the directory entry and so > gfs2_inode_lookup won't call gfs2_inode_refresh. > > In addition, only initialize ip->i_no_formal_ino from no_formal_ino when > actually needed. > > Signed-off-by: Andreas Gruenbacher > --- Hi, The patch looks good, but can we please change the description from: "trashing" to: "thrashing"? Reviewed-by: Bob Peterson Thanks. Bob Peterson Red Hat File Systems