All of lore.kernel.org
 help / color / mirror / Atom feed
From: akolli@codeaurora.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: ath11k@lists.infradead.org
Subject: Re: [bug report] ath11k: Add qcn9074 mhi controller config
Date: Fri, 19 Mar 2021 13:49:52 +0530	[thread overview]
Message-ID: <794462b263f0e95da49d1118cc7c44cf@codeaurora.org> (raw)
In-Reply-To: <YFNR+z1gab7MKkQv@mwanda>

Hi Dan Carpenter,

> The patch a233811ef600: "ath11k: Add qcn9074 mhi controller config"
> from Feb 16, 2021, leads to the following static checker warning:
> 
> 	drivers/net/wireless/ath/ath11k/mhi.c:357 ath11k_mhi_register()
> 	error: uninitialized symbol 'ath11k_mhi_config'.
> 

I will fix this.

> drivers/net/wireless/ath/ath11k/mhi.c
>    342          mhi_ctrl->iova_stop = 0xffffffff;
>    343          mhi_ctrl->sbl_size = SZ_512K;
>    344          mhi_ctrl->seg_len = SZ_512K;
>    345          mhi_ctrl->fbc_download = true;
>    346          mhi_ctrl->runtime_get = ath11k_mhi_op_runtime_get;
>    347          mhi_ctrl->runtime_put = ath11k_mhi_op_runtime_put;
>    348          mhi_ctrl->status_cb = ath11k_mhi_op_status_cb;
>    349          mhi_ctrl->read_reg = ath11k_mhi_op_read_reg;
>    350          mhi_ctrl->write_reg = ath11k_mhi_op_write_reg;
>    351
>    352          if (ab->hw_rev == ATH11K_HW_QCA6390_HW20)
>    353                  ath11k_mhi_config = &ath11k_mhi_config_qca6390;
>    354          else if (ab->hw_rev == ATH11K_HW_QCN9074_HW10)
>    355                  ath11k_mhi_config = &ath11k_mhi_config_qcn9074;
> 
> ath11k_mhi_config not initialized for other revs.  Which seem to exist
> so this seems like it could be a real bug?

mhi.c is only for PCI devices and in current ath11k driver only these 
two
hw_rev uses ath11k_mhi_config.

Thanks
Anil

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

      reply	other threads:[~2021-03-19  8:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 13:13 [bug report] ath11k: Add qcn9074 mhi controller config Dan Carpenter
2021-03-19  8:19 ` akolli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=794462b263f0e95da49d1118cc7c44cf@codeaurora.org \
    --to=akolli@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=dan.carpenter@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.