From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>,
"Gao, Chao" <chao.gao@intel.com>
Cc: "x86@kernel.org" <x86@kernel.org>, "bp@alien8.de" <bp@alien8.de>,
"binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>,
"kas@kernel.org" <kas@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"hpa@zytor.com" <hpa@zytor.com>,
"tglx@kernel.org" <tglx@kernel.org>
Subject: Re: [PATCH v3 02/10] x86/virt/tdx: Convert the version metadata reader
Date: Thu, 8 Oct 2026 16:58:05 +0000 [thread overview]
Message-ID: <794c12ff2f3759163bcb27465ce03e507e2910f0.camel@intel.com> (raw)
In-Reply-To: <asfJI+15tQivvy95@yilunxu-OptiPlex-7050>
On Fri, 2026-10-09 at 00:47 +0800, Xu Yilun wrote:
> I think something like the following is quite clear to me:
>
> static const struct field_mapping version_mappings[] = {
> FIELD_MAP(0x0800000100000003ULL, struct tdx_sys_info_version, minor_version),
> ...
> }
>
> or even:
>
> FIELD_MAP(0x0800000100000003ULL, version, minor_version),
>
> It clearly tells the mapping for the class, the field, and the field_id.
>
> So I'm not sure what's the downside of a literal hex here. To me, a
> TDX_FIELD_XX MACRO only creates duplicated names in one line and
> unnecessary touch points when we add a new field.
Hmm, yea that is an interesting point.
A point against is that the define names match the "Field" column in the docs.
So there is some extra robustness there. But I can see your way too. Hmm...
next prev parent reply other threads:[~2026-10-08 16:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 5:38 [PATCH v3 00/10] TDX: Stop auto-generating the global metadata code Chao Gao
2026-09-30 5:38 ` [PATCH v3 01/10] x86/virt/tdx: Add a helper to read a table of metadata fields Chao Gao
2026-10-01 0:30 ` Edgecombe, Rick P
2026-10-01 16:19 ` Nikolay Borisov
2026-09-30 5:38 ` [PATCH v3 02/10] x86/virt/tdx: Convert the version metadata reader Chao Gao
2026-10-01 0:30 ` Edgecombe, Rick P
2026-10-01 16:24 ` Nikolay Borisov
2026-10-01 16:27 ` Dave Hansen
2026-10-02 12:09 ` Chao Gao
2026-10-02 12:11 ` Nikolay Borisov
2026-10-08 16:47 ` Xu Yilun
2026-10-08 16:58 ` Edgecombe, Rick P [this message]
2026-10-09 3:15 ` Chao Gao
2026-09-30 5:38 ` [PATCH v3 03/10] x86/virt/tdx: Convert the features " Chao Gao
2026-10-01 0:30 ` Edgecombe, Rick P
2026-09-30 5:38 ` [PATCH v3 04/10] x86/virt/tdx: Convert the tdmr " Chao Gao
2026-10-01 0:31 ` Edgecombe, Rick P
2026-09-30 5:38 ` [PATCH v3 05/10] x86/virt/tdx: Convert the td_ctrl " Chao Gao
2026-10-01 0:31 ` Edgecombe, Rick P
2026-09-30 5:38 ` [PATCH v3 06/10] x86/virt/tdx: Convert the handoff " Chao Gao
2026-10-01 0:31 ` Edgecombe, Rick P
2026-09-30 5:38 ` [PATCH v3 07/10] x86/virt/tdx: Convert the td_conf " Chao Gao
2026-09-30 23:54 ` Edgecombe, Rick P
2026-10-01 12:08 ` Chao Gao
2026-10-01 16:34 ` Nikolay Borisov
2026-10-01 20:28 ` Edgecombe, Rick P
2026-10-02 12:28 ` Chao Gao
2026-10-02 12:32 ` Nikolay Borisov
2026-09-30 5:38 ` [PATCH v3 08/10] x86/virt/tdx: Remove tdx_global_metadata.c Chao Gao
2026-09-30 5:38 ` [PATCH v3 09/10] x86/virt/tdx: Use early returns in get_tdx_sys_info() Chao Gao
2026-10-01 0:30 ` Edgecombe, Rick P
2026-10-01 13:05 ` Chao Gao
2026-09-30 5:38 ` [PATCH v3 10/10] x86/virt/tdx: Verify structure member sizes against metadata field IDs Chao Gao
2026-10-01 0:29 ` Edgecombe, Rick P
2026-10-01 13:01 ` Chao Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=794c12ff2f3759163bcb27465ce03e507e2910f0.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=bp@alien8.de \
--cc=chao.gao@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=tony.lindgren@linux.intel.com \
--cc=x86@kernel.org \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.