From mboxrd@z Thu Jan 1 00:00:00 1970 From: david@lechnology.com (David Lechner) Date: Thu, 4 Jan 2018 15:22:25 -0600 Subject: [PATCH v4 6/7] ARM: davinci: convert to common clock framework In-Reply-To: References: <1514763588-31560-1-git-send-email-david@lechnology.com> <1514763588-31560-7-git-send-email-david@lechnology.com> Message-ID: <7950489e-2e66-9ed6-9b4e-239dce6bf87a@lechnology.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/04/2018 01:26 PM, Adam Ford wrote: > On Thu, Jan 4, 2018 at 11:50 AM, David Lechner wrote: >> >> >> On 1/4/18 6:39 AM, Sekhar Nori wrote: >>> >>> On Monday 01 January 2018 05:09 AM, David Lechner wrote: >>>> >>>> This converts all of arch/arm/mach-davinci to the common clock framework. >>>> The clock drivers from clock.c and psc.c have been moved to drivers/clk, >>>> so these files are removed. >>>> >>>> There is one subtle change in the clock trees. AUX, BPDIV and OSCDIV >>>> clocks now have "ref_clk" as a parent instead of the PLL clock. These >>>> clocks are part of the PLL's MMIO block, but they bypass the PLL and >>>> therefore it makes more sense to have "ref_clk" as their parent since >>>> "ref_clk" is the input clock of the PLL. >>>> >>>> CONFIG_DAVINCI_RESET_CLOCKS is removed since the common clock frameworks >>>> takes care of disabling unused clocks. >>>> >>>> Known issue: This breaks CPU frequency scaling on da850. >>> >>> >>> This functionality needs to be restored as part of this series since we >>> cannot commit anything with regressions. >>> >> >> Do you have a suggestion on how to accomplish this? I don't have a board for >> testing, so I don't have a way of knowing if my changes will work or not. > > I work for Logic PD who makes the original da850-evm. I can help if > you want to send me patches. It would be better if you had a git repo > setup where I could just clone the repo and tests. > > Having a larger collection of smaller the patches would also give me > the ability to bisect down to help determine what actually breaks the > da850-evm vs a few large patches. > > Do you still need me to run the board with some of the extra debugging > enabled, or should I wait for the next round of patches? > You might as well wait until I resubmit. There are going to be some significant changes. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753225AbeADVWa (ORCPT + 1 other); Thu, 4 Jan 2018 16:22:30 -0500 Received: from vern.gendns.com ([206.190.152.46]:54576 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752601AbeADVW2 (ORCPT ); Thu, 4 Jan 2018 16:22:28 -0500 Subject: Re: [PATCH v4 6/7] ARM: davinci: convert to common clock framework To: Adam Ford Cc: Sekhar Nori , linux-arm-kernel@lists.infradead.org, Kevin Hilman , linux-kernel@vger.kernel.org References: <1514763588-31560-1-git-send-email-david@lechnology.com> <1514763588-31560-7-git-send-email-david@lechnology.com> From: David Lechner Message-ID: <7950489e-2e66-9ed6-9b4e-239dce6bf87a@lechnology.com> Date: Thu, 4 Jan 2018 15:22:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/04/2018 01:26 PM, Adam Ford wrote: > On Thu, Jan 4, 2018 at 11:50 AM, David Lechner wrote: >> >> >> On 1/4/18 6:39 AM, Sekhar Nori wrote: >>> >>> On Monday 01 January 2018 05:09 AM, David Lechner wrote: >>>> >>>> This converts all of arch/arm/mach-davinci to the common clock framework. >>>> The clock drivers from clock.c and psc.c have been moved to drivers/clk, >>>> so these files are removed. >>>> >>>> There is one subtle change in the clock trees. AUX, BPDIV and OSCDIV >>>> clocks now have "ref_clk" as a parent instead of the PLL clock. These >>>> clocks are part of the PLL's MMIO block, but they bypass the PLL and >>>> therefore it makes more sense to have "ref_clk" as their parent since >>>> "ref_clk" is the input clock of the PLL. >>>> >>>> CONFIG_DAVINCI_RESET_CLOCKS is removed since the common clock frameworks >>>> takes care of disabling unused clocks. >>>> >>>> Known issue: This breaks CPU frequency scaling on da850. >>> >>> >>> This functionality needs to be restored as part of this series since we >>> cannot commit anything with regressions. >>> >> >> Do you have a suggestion on how to accomplish this? I don't have a board for >> testing, so I don't have a way of knowing if my changes will work or not. > > I work for Logic PD who makes the original da850-evm. I can help if > you want to send me patches. It would be better if you had a git repo > setup where I could just clone the repo and tests. > > Having a larger collection of smaller the patches would also give me > the ability to bisect down to help determine what actually breaks the > da850-evm vs a few large patches. > > Do you still need me to run the board with some of the extra debugging > enabled, or should I wait for the next round of patches? > You might as well wait until I resubmit. There are going to be some significant changes.